Skip to content

rustc versioning for features and overall min req. Sample smithy-http. #129

Closed
@johnsoncarlp

Description

@johnsoncarlp

Bug Report

Rustc version required. Update README and if possible add to toml for packages.

Version

all up to 0.0.9-alpha

Platform

Darwin 19.6.0 Darwin Kernel Version 19.6.0: Thu May 6 00:48:39 PDT 2021; root:xnu-6153.141.33~1/RELEASE_X86_64 x86_64

Description

rust-lang/rust#63514

rustc min version for features used. For example, poll was an unstable feature until early 2021, so if features like poll are used we should put the min rustc version required in the Cargo.toml so the user compiling can quickly diagnose vs hunting for a supported version.

In this sample the version required is 1.51.0 and of course I was on 1.49.0 ..

https://github.com/awslabs/aws-sdk-rust/blob/00c6d6f350cf45e2cdd8e3a9fdec6e24bbb63142/sdk/smithy-http/Cargo.toml

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions