Skip to content

Commit fdf2702

Browse files
committed
Now puts up a loading overlay over the onboarding create form
1 parent 3138a0f commit fdf2702

File tree

2 files changed

+26
-40
lines changed

2 files changed

+26
-40
lines changed

client/web/src/onboarding/OnboardingCreateContainer.js

Lines changed: 21 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import React, { useEffect, useState } from 'react'
1818
import { useHistory } from 'react-router-dom'
1919

20+
import LoadingOverlay from '@ronchalant/react-loading-overlay'
2021
import OnboardingFormComponent from './OnboardingFormComponent'
2122
import {
2223
createOnboarding,
@@ -25,40 +26,23 @@ import {
2526
selectErrorName,
2627
} from './ducks'
2728
import { useDispatch, useSelector } from 'react-redux'
28-
import { selectConfig, fetchConfig } from '../settings/ducks'
29-
import {
30-
fetchPlans,
31-
selectAllPlans,
32-
selectPlanLoading,
33-
selectPlanError,
34-
} from '../billing/ducks'
29+
import { selectConfig } from '../settings/ducks'
30+
import { selectAllPlans } from '../billing/ducks'
3531
import { saveToPresignedBucket } from '../settings/ducks'
3632
import { selectAllTiers } from '../tier/ducks'
37-
export default function OnboardingCreateContainer(props) {
33+
34+
export default function OnboardingCreateContainer() {
3835
const dispatch = useDispatch()
3936
const history = useHistory()
40-
41-
const loading = useSelector(selectLoading)
37+
const config = useSelector(selectConfig)
4238
const error = useSelector(selectError)
4339
const errorName = useSelector(selectErrorName)
44-
45-
const config = useSelector(selectConfig)
46-
47-
const loadingPlans = useSelector(selectPlanLoading)
48-
const errorPlans = useSelector(selectPlanError)
49-
const tiers = useSelector(selectAllTiers)
40+
const loading = useSelector(selectLoading)
5041
const plans = useSelector(selectAllPlans)
42+
const tiers = useSelector(selectAllTiers)
5143

5244
const [file, setFile] = useState({})
5345

54-
useEffect(() => {
55-
const billingPlansResponse = dispatch(fetchPlans())
56-
}, [dispatch])
57-
58-
useEffect(() => {
59-
const fetchConfigResponse = dispatch(fetchConfig())
60-
}, [dispatch])
61-
6246
const nullBlankProps = (obj) => {
6347
const ret = { ...obj }
6448
Object.keys(ret).forEach((key) => {
@@ -107,16 +91,18 @@ export default function OnboardingCreateContainer(props) {
10791
}
10892

10993
return (
110-
<OnboardingFormComponent
111-
billingPlans={plans}
112-
cancel={cancel}
113-
config={config}
114-
error={error}
115-
errorName={errorName}
116-
loading={loading}
117-
onFileSelected={handleFileSelected}
118-
submit={submitOnboardingRequestForm}
119-
tiers={tiers}
120-
/>
94+
<LoadingOverlay active={!loading} spinner text="Loading...">
95+
<OnboardingFormComponent
96+
billingPlans={plans}
97+
cancel={cancel}
98+
config={config}
99+
error={error}
100+
errorName={errorName}
101+
loading={loading}
102+
onFileSelected={handleFileSelected}
103+
submit={submitOnboardingRequestForm}
104+
tiers={tiers}
105+
/>
106+
</LoadingOverlay>
121107
)
122108
}

client/web/src/settings/ApplicationContainer.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,15 @@ export function ApplicationContainer(props) {
4646
const LINUX = 'LINUX'
4747

4848
const dispatch = useDispatch()
49-
const settings = useSelector(selectAllSettings)
50-
const loading = useSelector(selectLoading)
5149
const appConfig = useSelector(selectConfig)
52-
const dbOptions = useSelector(selectDbOptions)
53-
const osOptions = useSelector(selectOsOptions)
50+
const configError = useSelector(selectConfigError)
5451
const configLoading = useSelector(selectConfigLoading)
5552
const configMessage = useSelector(selectConfigMessage)
56-
const configError = useSelector(selectConfigError)
53+
const dbOptions = useSelector(selectDbOptions)
54+
const loading = useSelector(selectLoading)
55+
const osOptions = useSelector(selectOsOptions)
5756
const serviceToS3BucketMap = useSelector(selectServiceToS3BucketMap)
57+
const settings = useSelector(selectAllSettings)
5858

5959
const hasTenants = useSelector((state) => {
6060
return selectAllTenants(state)?.length > 0

0 commit comments

Comments
 (0)