java.nio.file.Path uses OS dependent file separator character but we (#184)

assume a forward slash to separate "folders" in S3 keys

Author: brtrvn

installer/src/main/java/com/amazon/aws/partners/saasfactory/saasboost/SaaSBoostArtifactsBucket.java

@@ -62,7 +62,10 @@ public void putFile(S3Client s3, Path localPath, Path remotePath) {
             LOGGER.debug("Putting {} to Artifacts bucket: {}", localPath, this);
             s3.putObject(PutObjectRequest.builder()
                     .bucket(bucketName)
-                    .key(remotePath.toString())
+                    // java.nio.file.Path will use OS dependent file separators, so when we run the installer on
+                    // Windows, the S3 key will have back slashes instead of forward slashes. The CloudFormation
+                    // definitions of the Lambda functions will always use forward slashes for the S3Key property.
+                    .key(remotePath.toString().replace('\\', '/'))
                     .build(), RequestBody.fromFile(localPath)
             );
         } catch (SdkServiceException s3Error) {

installer/src/test/java/com/amazon/aws/partners/saasfactory/saasboost/SaaSBoostArtifactsBucketTest.java

@@ -60,7 +60,7 @@ public void putFileTest() throws Exception {
         assertEquals("Put object to the wrong bucket.",
                 testBucket.getBucketName(), putObjectRequestArgumentCaptor.getValue().bucket());
         assertEquals("Put object to the wrong location.",
-                exampleRemotePath.toString(), putObjectRequestArgumentCaptor.getValue().key());
+                exampleRemotePath.toString().replace('\\', '/'), putObjectRequestArgumentCaptor.getValue().key());
         assertEquals("Put different length object to remote location. Wrong file?",
                 localPathToTestPut.toFile().length(), requestBodyArgumentCaptor.getValue().contentLength());
     }