Skip to content

Commit 33b0b2a

Browse files
committed
Merge branch 'multi-container' of github.com:awslabs/aws-saas-boost into multi-container
2 parents 541bb02 + b431dec commit 33b0b2a

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

resources/custom-resources/app-services-ecr-macro/src/main/java/com/amazon/aws/partners/saasfactory/saasboost/ApplicationServicesEcrMacro.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ protected static String ecrResourceName(String serviceName) {
9696
if (Utils.isBlank(serviceName)) {
9797
throw new IllegalArgumentException("service name cannot be blank");
9898
}
99-
return cloudFormationResourceName(serviceName).toLowerCase();
99+
return cloudFormationResourceName(serviceName);
100100
}
101101

102102
protected static Map<String, Object> ecrResource(String serviceName) {

resources/custom-resources/app-services-ecr-macro/src/test/java/com/amazon/aws/partners/saasfactory/saasboost/ApplicationServicesEcrMacroTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,22 +50,22 @@ public void testResourceName() {
5050
assertEquals(expected, actual);
5151

5252
serviceName = "Foo";
53-
expected = "foo";
53+
expected = "Foo";
5454
actual = ApplicationServicesEcrMacro.ecrResourceName(serviceName);
5555
assertEquals(expected, actual);
5656

5757
serviceName = "Foo Bar";
58-
expected = "foobar";
58+
expected = "FooBar";
5959
actual = ApplicationServicesEcrMacro.ecrResourceName(serviceName);
6060
assertEquals(expected, actual);
6161

6262
serviceName = "Foo_Bar";
63-
expected = "foobar";
63+
expected = "FooBar";
6464
actual = ApplicationServicesEcrMacro.ecrResourceName(serviceName);
6565
assertEquals(expected, actual);
6666

6767
serviceName = "Foo-Bar";
68-
expected = "foobar";
68+
expected = "FooBar";
6969
actual = ApplicationServicesEcrMacro.ecrResourceName(serviceName);
7070
assertEquals(expected, actual);
7171
}
@@ -104,16 +104,16 @@ public void testHandleRequest() throws Exception {
104104
assertTrue(resources.containsKey("foo"));
105105
assertTrue(resources.containsKey("ImageEventRulefoo"));
106106
assertTrue(resources.containsKey("ImageEventPermissionfoo"));
107-
assertTrue(resources.containsKey("bar"));
107+
assertTrue(resources.containsKey("Bar"));
108108
assertTrue(resources.containsKey("ImageEventRuleBar"));
109109
assertTrue(resources.containsKey("ImageEventPermissionBar"));
110-
assertTrue(resources.containsKey("bazoole"));
110+
assertTrue(resources.containsKey("bazOole"));
111111
assertTrue(resources.containsKey("ImageEventRulebazOole"));
112112
assertTrue(resources.containsKey("ImageEventPermissionbazOole"));
113113

114114
// There should be a single tag for Name and it should have the non-modified application service name
115115
// for its Value
116-
List<Map<String, Object>> tags = (List<Map<String, Object>>) ((LinkedHashMap<String, Object>) ((LinkedHashMap<String, Object>) resources.get("bazoole")).get("Properties")).get("Tags");
116+
List<Map<String, Object>> tags = (List<Map<String, Object>>) ((LinkedHashMap<String, Object>) ((LinkedHashMap<String, Object>) resources.get("bazOole")).get("Properties")).get("Tags");
117117
assertEquals(1, tags.size());
118118
assertEquals("baz Oole", tags.get(0).get("Value"));
119119
}

0 commit comments

Comments
 (0)