fix: Accept "convertToNull" value for property "zeroDateTimeBehaviour" #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
reviewed
Jun 6, 2023
Comment on lines
229
to
235
| Properties props = new Properties(); | ||
| for (Map.Entry<String, String> entry : connectionUrl.getMainHost().getHostProperties().entrySet()) { | ||
| if (entry.getValue() != null) { | ||
| props.put(entry.getKey(), entry.getValue()); | ||
| } | ||
| } | ||
| this.connProps.initializeProperties(props); |
There was a problem hiding this comment.
Suggested change
| Properties props = new Properties(); | |
| for (Map.Entry<String, String> entry : connectionUrl.getMainHost().getHostProperties().entrySet()) { | |
| if (entry.getValue() != null) { | |
| props.put(entry.getKey(), entry.getValue()); | |
| } | |
| } | |
| this.connProps.initializeProperties(props); | |
| final Properties props = new Properties(); | |
| props.putAll(connectionUrl.getMainHost().getHostProperties()); | |
| this.connProps.initializeProperties(props); |
There was a problem hiding this comment.
This will cause a null pointer exception if one of the properties is null.
crystall-bitquill
force-pushed
the
issue-411
branch
from
c7fb02e to
653acd5
Compare
karenc-bq
approved these changes
Jun 8, 2023
crystall-bitquill
force-pushed
the
issue-411
branch
from
653acd5 to
f8916a5
Compare
hsuamz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Accept "convertToNull" value for property "zeroDateTimeBehaviour"
Description
Some connection properties such as
zeroDateTimeBehaviourare altered in thefixHostInfomethod. ThezeroDateTimeBehaviourvalue in particular is replaced in thereplaceLegacyPropertyValuesmethod. This allows the driver to accept both upper and lowercase values. When the driver detects an AWS JDBC Driver protocol, it will create a proxy using the properties the user specified and not the corrected set. This PR will use the "fixed" properties instead.Addresses issue #411.
Additional Reviewers