Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Custom host #21

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Custom host #21

merged 1 commit into from
Dec 20, 2018

Conversation

sapessi
Copy link
Collaborator

@sapessi sapessi commented Dec 19, 2018

Added the ability to customize the hostname for the request with the GO_API_HOST environment variable. The variable should contain both a protocol and host. For example http://my-custom-host.com

Issue #, if available: #13

Description of changes:

  • Added env variable check while creating http request
  • Added tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@jeroenkoknl jeroenkoknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sapessi Thank you for these changes. They look good to me!

@sapessi sapessi merged commit 5e02399 into master Dec 20, 2018
@huyphan huyphan mentioned this pull request Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants