fix: Improve error handling and visibility in S3DirectoryStream #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
implements #189 |
stefanofornari
pushed a commit
to stefanofornari/aws-java-nio-spi-for-s3
that referenced
this pull request
Mar 16, 2024
…abs#404) * fix: Improve error handling and visibility in S3DirectoryStream
stefanofornari
pushed a commit
to stefanofornari/aws-java-nio-spi-for-s3
that referenced
this pull request
May 20, 2024
…abs#404) * fix: Improve error handling and visibility in S3DirectoryStream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#189
Description of changes:
SDK exceptions in the S3DirectoryStream are now explicitly perpetuated as some type of IOException to enable them to be more easily caught and handled. Added tests where service mocks generate various SdkExceptions to ensure these are perpetuated.
Some general cleanup and fixing imports to match new stylecheck added for v2
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.