rewrite(S3FileSystemProvider): instantiate S3FileAttributes once #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guicamest
force-pushed
the
rewriteReadAttributes
branch
2 times, most recently
from
2eba11c to
dce6b31
Compare
Contributor
|
Looks good but the change to using |
…ove `asMap()` with no filter
guicamest
force-pushed
the
rewriteReadAttributes
branch
from
dce6b31 to
ff1b535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The rewrite unifies the
returns fromreadAttributestaking advantage of the filter option. As a consequence,asMap()method fromS3BasicFileAttributesis not used anymore, so it has been cleaned up.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.