refactor(S3ClientProvider): Reduce complexity of generateClient
#248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom generateSyncClient and generateAsyncClient
…cationFromHead methods
guicamest
force-pushed
the
generateClientRefactor
branch
from
3be97b7 to
13d1e3d
Compare
markjschreiber
approved these changes
Nov 1, 2023
Contributor
markjschreiber
left a comment
markjschreiber
left a comment
There was a problem hiding this comment.
Thanks for tidying up this code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The
generateClient(andgenerateAsyncClient) method was quite complex, had several nested blocks (if/try/if/try/if). Some new methods have been extracted in order to make the code more readable and maintainable.Both
generateClientandgenerateAsyncClientshared the same logic - except for the underlying client that was generated. A new methodgetClientForBuckethas been extracted that receives a function to construct the client for the given bucket location. The oldgenerateClienthas been renamed togenerateSyncClient.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.