chore(test): Improve S3FileSystemProviderTest robustness #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guicamest
force-pushed
the
improveTestRobustness
branch
from
cce50e7 to
18b8bf3
Compare
guicamest
changed the title
markjschreiber
approved these changes
Oct 2, 2023
Contributor
markjschreiber
left a comment
markjschreiber
left a comment
There was a problem hiding this comment.
Thanks for spotting and fixing this problem!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
After checking out the project and running the tests, they would fail or not depending on the order the tests are run (it is not guaranteed they are by default).
I've noticed
S3PathTest.testEqualscreatesfoofs but it is not closed;S3FileSystemProviderTestusesfoofs for its tests.So this PR introduces 2 changes:
testEqualsafter creating itS3FileSystemProviderTestso that it is not affected by other tests leaking resourcesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.