cleanup(S3ClientProvider): Remove constructor used only in tests

Author: guicamest

src/main/java/software/amazon/nio/spi/s3/S3ClientProvider.java

@@ -105,10 +105,6 @@ public S3ClientProvider(S3NioSpiConfiguration c) {
         this.configuration = (c == null) ? new S3NioSpiConfiguration() : c;
     }
 
-    public S3ClientProvider() {
-        this(null);
-    }
-
     public S3CrtAsyncClientBuilder asyncClientBuilder() {
         return asyncClientBuilder;
     }

src/test/java/software/amazon/nio/spi/s3/FixedS3ClientProvider.java

@@ -19,6 +19,7 @@ public class FixedS3ClientProvider extends S3ClientProvider {
     final public AwsClient client;
 
     public FixedS3ClientProvider(S3AsyncClient client) {
+        super(null);
         this.client = client;
     }
 

src/test/java/software/amazon/nio/spi/s3/S3ClientProviderTest.java

@@ -37,13 +37,13 @@ public class S3ClientProviderTest {
     S3ClientProvider provider;
 
     @BeforeEach
-    public void before() throws Exception {
-        provider = new S3ClientProvider();
+    public void before() {
+        provider = new S3ClientProvider(null);
     }
 
     @Test
     public void initialization() {
-        final S3ClientProvider P = new S3ClientProvider();
+        final S3ClientProvider P = new S3ClientProvider(null);
 
         assertNotNull(P.configuration);
 

src/test/java/software/amazon/nio/spi/s3/S3FileSystemTest.java

@@ -88,8 +88,8 @@ public void isReadOnly() {
 
     @Test
     public void getAndSetClientProvider() {
-        final S3ClientProvider P1 = new S3ClientProvider();
-        final S3ClientProvider P2 = new S3ClientProvider();
+        final S3ClientProvider P1 = new S3ClientProvider(null);
+        final S3ClientProvider P2 = new S3ClientProvider(null);
         s3FileSystem.clientProvider(P1); then(s3FileSystem.clientProvider()).isSameAs(P1);
         s3FileSystem.clientProvider(P2); then(s3FileSystem.clientProvider()).isSameAs(P2);
     }