Skip to content

fix resume token class cache #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TingDaoK merged 1 commit into from
May 24, 2024
Merged

fix resume token class cache #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/java/software/amazon/awssdk/crt/s3/ResumeToken.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public PutResumeTokenBuilder withUploadId(String uploadId) {

public ResumeToken build() {
return new ResumeToken(this);
}
}
};

private int nativeType;
Expand All @@ -71,6 +71,10 @@ public ResumeToken(PutResumeTokenBuilder builder) {
this.numPartsCompleted = builder.numPartsCompleted;
this.uploadId = builder.uploadId;
}
/**
* Default constructor
*/
private ResumeToken() {}

/******
* Common Fields.
Expand Down Expand Up @@ -106,7 +110,7 @@ public long getNumPartsCompleted() {
}

/******
* Upload Specific fields.
* Upload Specific fields.
******/
/**
* @return upload Id
Expand Down
9 changes: 7 additions & 2 deletions src/native/java_class_ids.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -967,18 +967,23 @@ static void s_cache_s3_meta_request_resume_token(JNIEnv *env) {
AWS_FATAL_ASSERT(cls);
s3_meta_request_resume_token_properties.s3_meta_request_resume_token_class = (*env)->NewGlobalRef(env, cls);

s3_meta_request_resume_token_properties.s3_meta_request_resume_token_constructor_method_id =
(*env)->GetMethodID(env, s3_meta_request_progress_properties.s3_meta_request_progress_class, "<init>", "()V");
s3_meta_request_resume_token_properties.s3_meta_request_resume_token_constructor_method_id = (*env)->GetMethodID(
env, s3_meta_request_resume_token_properties.s3_meta_request_resume_token_class, "<init>", "()V");
AWS_FATAL_ASSERT(s3_meta_request_resume_token_properties.s3_meta_request_resume_token_constructor_method_id);

s3_meta_request_resume_token_properties.native_type_field_id = (*env)->GetFieldID(env, cls, "nativeType", "I");
AWS_FATAL_ASSERT(s3_meta_request_resume_token_properties.native_type_field_id);
s3_meta_request_resume_token_properties.part_size_field_id = (*env)->GetFieldID(env, cls, "partSize", "J");
AWS_FATAL_ASSERT(s3_meta_request_resume_token_properties.part_size_field_id);
s3_meta_request_resume_token_properties.total_num_parts_field_id =
(*env)->GetFieldID(env, cls, "totalNumParts", "J");
AWS_FATAL_ASSERT(s3_meta_request_resume_token_properties.total_num_parts_field_id);
s3_meta_request_resume_token_properties.num_parts_completed_field_id =
(*env)->GetFieldID(env, cls, "numPartsCompleted", "J");
AWS_FATAL_ASSERT(s3_meta_request_resume_token_properties.num_parts_completed_field_id);
s3_meta_request_resume_token_properties.upload_id_field_id =
(*env)->GetFieldID(env, cls, "uploadId", "Ljava/lang/String;");
AWS_FATAL_ASSERT(s3_meta_request_resume_token_properties.upload_id_field_id);
}

struct java_aws_mqtt5_connack_packet_properties mqtt5_connack_packet_properties;
Expand Down