Skip to content

Conversation

@waahm7
Copy link
Contributor

@waahm7 waahm7 commented Feb 7, 2023

Description of changes:

  • Adds reference counting to Profile collection

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@waahm7 waahm7 marked this pull request as ready for review February 7, 2023 23:12
@waahm7 waahm7 changed the title WIP | Add Reference Count to Profile Collection Add Reference Count to Profile Collection Feb 7, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 67.66% // Head: 67.78% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (341c33c) compared to base (8e341f2).
Patch coverage: 61.53% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   67.66%   67.78%   +0.12%     
==========================================
  Files           9        9              
  Lines        2576     2564      -12     
==========================================
- Hits         1743     1738       -5     
+ Misses        833      826       -7     
Impacted Files Coverage Δ
source/aws_profile.c 66.24% <61.53%> (-0.54%) ⬇️
source/endpoints_ruleset.c 61.86% <0.00%> (+0.12%) ⬆️
source/endpoints_rule_engine.c 61.16% <0.00%> (+0.33%) ⬆️
source/endpoints_standard_lib.c 72.19% <0.00%> (+0.38%) ⬆️
source/endpoints_util.c 74.10% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TingDaoK TingDaoK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix and ship

@waahm7 waahm7 merged commit c98a341 into main Feb 13, 2023
@waahm7 waahm7 deleted the profile-collection-refcount branch February 13, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants