Remove null check for aws_pkcs11_lib_login_user (#611)

xiazhvera · web-flow · commit 8583ba74fed0 · 2023-10-16T14:48:30.000-07:00
diff --git a/source/pkcs11_tls_op_handler.c b/source/pkcs11_tls_op_handler.c
@@ -183,10 +183,8 @@ struct aws_custom_key_op_handler *aws_pkcs11_tls_op_handler_new(
         goto done;
     }
 
-    if (pkcs_user_pin != NULL) {
-        if (aws_pkcs11_lib_login_user(pkcs11_handler->lib, pkcs11_handler->session_handle, pkcs_user_pin)) {
-            goto done;
-        }
+    if (aws_pkcs11_lib_login_user(pkcs11_handler->lib, pkcs11_handler->session_handle, pkcs_user_pin)) {
+        goto done;
     }
 
     if (aws_pkcs11_lib_find_private_key(

Original file line number	Diff line number	Diff line change
`@@ -183,10 +183,8 @@ struct aws_custom_key_op_handler *aws_pkcs11_tls_op_handler_new(`
`183`	`183`	`goto done;`
`184`	`184`	`}`
`185`	`185`
`186`		`- if (pkcs_user_pin != NULL) {`
`187`		`- if (aws_pkcs11_lib_login_user(pkcs11_handler->lib, pkcs11_handler->session_handle, pkcs_user_pin)) {`
`188`		`- goto done;`
`189`		`- }`
	`186`	`+ if (aws_pkcs11_lib_login_user(pkcs11_handler->lib, pkcs11_handler->session_handle, pkcs_user_pin)) {`
	`187`	`+ goto done;`
`190`	`188`	`}`
`191`	`189`
`192`	`190`	`if (aws_pkcs11_lib_find_private_key(`