Skip to content

Re-enable and fix test #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2019
Merged

Re-enable and fix test #28

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dff4c1c
Re-enable and fix test
graebm Apr 4, 2019
4bd5c63
Merge branch 'master' into rebug-delease
graebm Apr 4, 2019
5a3d669
Turn test off again.
graebm Apr 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/test_connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,11 @@ static void s_tester_on_server_connection_shutdown(
(void)connection;
(void)error_code;
struct tester *tester = user_data;
AWS_FATAL_ASSERT(aws_mutex_lock(&tester->wait_lock) == AWS_OP_SUCCESS);

tester->server_connection_is_shutdown = true;

AWS_FATAL_ASSERT(aws_mutex_unlock(&tester->wait_lock) == AWS_OP_SUCCESS);
aws_condition_variable_notify_one(&tester->wait_cvar);
}

Expand All @@ -94,6 +97,7 @@ static void s_tester_on_server_connection_setup(

(void)server;
struct tester *tester = user_data;
AWS_FATAL_ASSERT(aws_mutex_lock(&tester->wait_lock) == AWS_OP_SUCCESS);

if (error_code) {
tester->wait_result = error_code;
Expand All @@ -113,6 +117,7 @@ static void s_tester_on_server_connection_setup(

tester->server_connection = connection;
done:
AWS_FATAL_ASSERT(aws_mutex_unlock(&tester->wait_lock) == AWS_OP_SUCCESS);
aws_condition_variable_notify_one(&tester->wait_cvar);
}

Expand All @@ -122,13 +127,16 @@ static void s_tester_on_client_connection_setup(
void *user_data) {

struct tester *tester = user_data;
AWS_FATAL_ASSERT(aws_mutex_lock(&tester->wait_lock) == AWS_OP_SUCCESS);

if (error_code) {
tester->wait_result = error_code;
goto done;
}

tester->client_connection = connection;
done:
AWS_FATAL_ASSERT(aws_mutex_unlock(&tester->wait_lock) == AWS_OP_SUCCESS);
aws_condition_variable_notify_one(&tester->wait_cvar);
}

Expand All @@ -140,8 +148,11 @@ static void s_tester_on_client_connection_shutdown(
(void)connection;
(void)error_code;
struct tester *tester = user_data;
AWS_FATAL_ASSERT(aws_mutex_lock(&tester->wait_lock) == AWS_OP_SUCCESS);

tester->client_connection_is_shutdown = true;

AWS_FATAL_ASSERT(aws_mutex_unlock(&tester->wait_lock) == AWS_OP_SUCCESS);
aws_condition_variable_notify_one(&tester->wait_cvar);
}

Expand Down