H2 setting frame #206
Merged
H2 setting frame #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
reviewed
Mar 27, 2020
graebm
reviewed
Mar 28, 2020
source/h2_connection.c
Outdated
Comment on lines
546
to
551
| static void s_aws_h2_connection_change_peer_settings( | ||
| struct aws_h2_connection *connection, | ||
| struct aws_h2_frame_setting setting) { | ||
| uint32_t *settings_peer = connection->thread_data.settings_peer; | ||
| settings_peer[setting.id] = setting.value; | ||
| } |
Contributor
There was a problem hiding this comment.
trivial: this doesn't need to be a function, it's 1 line long and called from 1 place
Contributor
Author
There was a problem hiding this comment.
I don't know, I just think it may have more functions, like informing others? But since the encoder is the only one who will be informed, it is not needed to be a function
source/h2_connection.c
Outdated
| aws_error_name(aws_last_error())); | ||
| goto error; | ||
| } | ||
| if (setting.id == AWS_H2_SETTINGS_HEADER_TABLE_SIZE) { |
Contributor
There was a problem hiding this comment.
trivial/efficiency: maybe just continue if new value matches existing value
Contributor
Author
There was a problem hiding this comment.
Same as the switch statement right?
Contributor
There was a problem hiding this comment.
like, before the switch we can just do:
if (connection->thread_data.settings_peer[setting.id] == setting.value) {
/* No change, don't do any work */
continue;
}
switch (setting.id)
...
graebm
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Finished the way when a Setting frame received. And decoder&encoder depending on the real setting values now.
TODO: