Ping frame for H2 #205
Merged
Ping frame for H2 #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do encoding in 2 passes, so we know exactly how much buffer space we'll need. I will probably revert this. I thought this was clever, but seeing it implemented it's just so much more complicated than writing everything to a dynamic buffer, then copying it into the aws_io_mesage.
ditch 2 pass approach, it was just too complicated
…match aws-c-io api changes. (#194)
As seen in real life
* Enabled compilation on VS 2015 * Fix VS narrowing warning * Updated to v0.5.3 of builder
Ignore connection: close on 200/OK responses to a CONNECT Request, since the proxy is obviously drunk and needs to hail an uber to get home from the bar safely. Fix the broken tests from the tcp back pressure refactor in aws-c-io.
- Use common struct - Pre-encode the entire frame - Incrementally copy that to aws_io_message whenever encode() is called. This is simpler/better because: 1) more shared code 2) unique payload-writing code all goes in the one new() function, instead of being spread across the new() and encode() functions 3) less chance of incorrect size calculations, since we're encoding to a buffer of the exact correct length
…If this kind of error happens now, it's programmer error
…into ping_frame
Extract useful machinery from test_h2_decoder.c for use with other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.