H2 test helper #204
Merged
H2 test helper #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract useful machinery from test_h2_decoder.c for use with other tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move code around so we can re-use helpers.
Most of this code was already reviewed here: #187
How to review this PR:
constto argumentsh2_test_helper.h/cstruct h2_decoded_frameused to bestruct frameintest_h2_decoder.cstruct h2_decode_testerused to bestruct fixtureintest_h2_decoder.cstruct h2_fake_peeris NEWtest_h2_client.c: rewrote one test to use the helpers, instead of comparing against binary data I'd typed out by hand.test_h2_decoder.c: massive changes not worth looking at, it's just from me moving/renaming the code.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.