Some trivial fixup on tests (#503)

- Remove the word "test" from any test name
- Add the word "decoder" to decoder tests
- Lots of fixup in h1_encoder tests:
    - Rename some tests to make more sense
    - Always assert that aws_h1_encoder_message_init_from_request() succeeds or fails. Previously a lot of tests weren't ACTUALLY testing anything!!! Fortunately no actual bugs were uncovered here.
    - Use the "bad request" helper in more places
    - Add "Host" header to all requests

Author: graebm

source/h1_encoder.c

@@ -124,7 +124,7 @@ static int s_scan_outgoing_headers(
     if (encoder_message->has_chunked_encoding_header && has_content_length_header) {
         AWS_LOGF_ERROR(
             AWS_LS_HTTP_STREAM, "id=static: Both Content-Length and Transfer-Encoding are set. Only one may be used");
-        return aws_raise_error(AWS_ERROR_HTTP_INVALID_HEADER_VALUE);
+        return aws_raise_error(AWS_ERROR_HTTP_INVALID_HEADER_FIELD);
     }
 
     if (encoder_message->has_chunked_encoding_header && has_body_stream) {

tests/CMakeLists.txt

@@ -36,35 +36,35 @@ add_test_case(message_response_status)
 add_test_case(message_refcounts)
 add_test_case(message_with_existing_headers)
 
-add_test_case(h1_test_get_request)
-add_test_case(h1_test_request_bad_version)
-add_test_case(h1_test_response_unsupported_version)
-add_test_case(h1_test_response_1_0)
-add_test_case(h1_test_get_status_code)
-add_test_case(h1_test_overflow_scratch_space)
-add_test_case(h1_test_receive_request_headers)
-add_test_case(h1_test_receive_response_headers)
-add_test_case(h1_test_get_transfer_encoding_flags)
-add_test_case(h1_test_body_unchunked)
-add_test_case(h1_test_body_chunked)
-add_test_case(h1_decode_trailers)
-add_test_case(h1_decode_one_byte_at_a_time)
-add_test_case(h1_decode_messages_at_random_intervals)
-add_test_case(h1_decode_bad_requests_and_assert_failure)
-add_test_case(h1_decode_bad_responses_and_assert_failure)
-add_test_case(h1_test_extraneous_buffer_data_ensure_not_processed)
-add_test_case(h1_test_ignore_chunk_extensions)
-
-add_test_case(h1_encoder_content_length_put_request_headers)
-add_test_case(h1_encoder_transfer_encoding_chunked_put_request_headers)
-add_test_case(h1_encoder_transfer_encoding_chunked_put_request_multiple_te_headers)
-add_test_case(h1_encoder_transfer_encoding_chunked_put_request_headers_case_insensitivity)
-add_test_case(h1_encoder_transfer_encoding_chunked_and_content_length_put_request_headers)
-add_test_case(h1_encoder_transfer_encoding_not_chunked_put_request_headers)
-add_test_case(h1_encoder_transfer_encoding_set_body_stream_errors)
-add_test_case(h1_encoder_transfer_encoding_chunked_multiple_put_request_headers)
-add_test_case(h1_encoder_transfer_encoding_chunked_not_final_encoding_put_request_headers)
-add_test_case(h1_encoder_transfer_encoding_not_ending_in_chunked_put_request_headers)
+add_test_case(h1_decoder_get_request)
+add_test_case(h1_decoder_request_bad_version)
+add_test_case(h1_decoder_response_unsupported_version)
+add_test_case(h1_decoder_response_1_0)
+add_test_case(h1_decoder_get_status_code)
+add_test_case(h1_decoder_overflow_scratch_space)
+add_test_case(h1_decoder_receive_request_headers)
+add_test_case(h1_decoder_receive_response_headers)
+add_test_case(h1_decoder_get_transfer_encoding_flags)
+add_test_case(h1_decoder_body_unchunked)
+add_test_case(h1_decoder_body_chunked)
+add_test_case(h1_decoder_trailers)
+add_test_case(h1_decoder_one_byte_at_a_time)
+add_test_case(h1_decoder_messages_at_random_intervals)
+add_test_case(h1_decoder_bad_requests_and_assert_failure)
+add_test_case(h1_decoder_bad_responses_and_assert_failure)
+add_test_case(h1_decoder_extraneous_buffer_data_ensure_not_processed)
+add_test_case(h1_decoder_ignore_chunk_extensions)
+
+add_test_case(h1_encoder_content_length_header)
+add_test_case(h1_encoder_transfer_encoding_chunked_header)
+add_test_case(h1_encoder_transfer_encoding_chunked_across_multiple_headers)
+add_test_case(h1_encoder_case_insensitive_header_names)
+add_test_case(h1_encoder_rejects_transfer_encoding_chunked_header_combined_with_content_length)
+add_test_case(h1_encoder_rejects_transfer_encoding_header_without_chunked)
+add_test_case(h1_encoder_rejects_transfer_encoding_chunked_header_combined_with_body_stream)
+add_test_case(h1_encoder_transfer_encoding_chunked_header_with_multiple_encodings)
+add_test_case(h1_encoder_rejects_transfer_encoding_header_when_chunked_not_final_encoding)
+add_test_case(h1_encoder_rejects_transfer_encoding_header_not_ending_in_chunked)
 add_test_case(h1_encoder_rejects_bad_method)
 add_test_case(h1_encoder_rejects_missing_method)
 add_test_case(h1_encoder_rejects_bad_path)
@@ -163,7 +163,7 @@ add_test_case(strutil_is_http_pseudo_header_name)
 
 add_net_test_case(tls_download_medium_file_h1)
 add_net_test_case(tls_download_medium_file_h2)
-add_net_test_case(test_tls_download_shutdown_with_window_size_0)
+add_net_test_case(tls_download_shutdown_with_window_size_0)
 
 add_test_case(websocket_decoder_sanity_check)
 add_test_case(websocket_decoder_simplest_frame)
@@ -522,31 +522,31 @@ add_net_test_case(connection_customized_alpn_error_with_unknown_return_string)
 
 # connection manager tests
 # unit tests where connections are mocked
-add_net_test_case(test_connection_manager_setup_shutdown)
-add_net_test_case(test_connection_manager_acquire_release_mix_synchronous)
-add_net_test_case(test_connection_manager_acquisition_timeout)
-add_net_test_case(test_connection_manager_connect_callback_failure)
-add_net_test_case(test_connection_manager_connect_immediate_failure)
-add_net_test_case(test_connection_manager_proxy_setup_shutdown)
-add_net_test_case(test_connection_manager_idle_culling_single)
-add_net_test_case(test_connection_manager_idle_culling_many)
-add_net_test_case(test_connection_manager_idle_culling_mixture)
-add_net_test_case(test_connection_manager_idle_culling_refcount)
-add_net_test_case(test_connection_manager_with_network_interface_list)
+add_net_test_case(connection_manager_setup_shutdown)
+add_net_test_case(connection_manager_acquire_release_mix_synchronous)
+add_net_test_case(connection_manager_acquisition_timeout)
+add_net_test_case(connection_manager_connect_callback_failure)
+add_net_test_case(connection_manager_connect_immediate_failure)
+add_net_test_case(connection_manager_proxy_setup_shutdown)
+add_net_test_case(connection_manager_idle_culling_single)
+add_net_test_case(connection_manager_idle_culling_many)
+add_net_test_case(connection_manager_idle_culling_mixture)
+add_net_test_case(connection_manager_idle_culling_refcount)
+add_net_test_case(connection_manager_with_network_interface_list)
 
 # tests where we establish real connections
-add_net_test_case(test_connection_manager_single_connection)
-add_net_test_case(test_connection_manager_proxy_envrionment_empty_string)
-add_net_test_case(test_connection_manager_single_http2_connection)
-add_net_test_case(test_connection_manager_single_http2_connection_failed)
-add_net_test_case(test_connection_manager_single_http2_connection_with_settings)
-add_net_test_case(test_connection_manager_many_connections)
-add_net_test_case(test_connection_manager_many_http2_connections)
-add_net_test_case(test_connection_manager_acquire_release)
-add_net_test_case(test_connection_manager_close_and_release)
-add_net_test_case(test_connection_manager_acquire_release_mix)
-add_net_test_case(test_connection_manager_max_pending_acquisitions)
-add_net_test_case(test_connection_manager_max_pending_acquisitions_with_vended_connections)
+add_net_test_case(connection_manager_single_connection)
+add_net_test_case(connection_manager_proxy_envrionment_empty_string)
+add_net_test_case(connection_manager_single_http2_connection)
+add_net_test_case(connection_manager_single_http2_connection_failed)
+add_net_test_case(connection_manager_single_http2_connection_with_settings)
+add_net_test_case(connection_manager_many_connections)
+add_net_test_case(connection_manager_many_http2_connections)
+add_net_test_case(connection_manager_acquire_release)
+add_net_test_case(connection_manager_close_and_release)
+add_net_test_case(connection_manager_acquire_release_mix)
+add_net_test_case(connection_manager_max_pending_acquisitions)
+add_net_test_case(connection_manager_max_pending_acquisitions_with_vended_connections)
 
 # Integration test that requires proxy envrionment in us-east-1 region.
 # TODO: test the server name validation properly
@@ -610,46 +610,46 @@ add_test_case(h1_server_error_from_outgoing_body_callback_stops_sending)
 add_test_case(h1_server_close_from_off_thread_makes_not_open)
 add_test_case(h1_server_close_from_on_thread_makes_not_open)
 
-add_test_case(test_http_forwarding_proxy_connection_proxy_target)
-add_test_case(test_http_forwarding_proxy_connection_channel_failure)
-add_test_case(test_http_forwarding_proxy_connection_connect_failure)
-add_test_case(test_http_forwarding_proxy_request_transform)
-add_test_case(test_http_forwarding_proxy_request_transform_basic_auth)
-add_test_case(test_http_forwarding_proxy_request_transform_legacy_basic_auth)
-add_test_case(test_http_proxy_request_transform_kerberos)
-add_test_case(test_http_proxy_kerberos_token_failure)
-add_test_case(test_http_proxy_kerberos_connect_failure)
-add_test_case(test_http_proxy_adaptive_identity_success)
-add_test_case(test_http_proxy_adaptive_kerberos_success)
-add_test_case(test_http_proxy_adaptive_ntlm_success)
-add_test_case(test_http_proxy_adaptive_failure)
-add_test_case(test_http_forwarding_proxy_uri_rewrite)
-add_test_case(test_http_forwarding_proxy_uri_rewrite_options_star)
-add_test_case(test_http_tunnel_proxy_connection_success)
-add_test_case(test_https_tunnel_proxy_connection_success)
-add_test_case(test_http_tunnel_proxy_connection_failure_connect)
-add_test_case(test_https_tunnel_proxy_connection_failure_connect)
-add_test_case(test_https_tunnel_proxy_connection_failure_tls)
-
-add_test_case(test_http_connection_monitor_options_is_valid)
-add_test_case(test_http_connection_monitor_rw_above)
-add_test_case(test_http_connection_monitor_r_above)
-add_test_case(test_http_connection_monitor_w_above)
-add_test_case(test_http_connection_monitor_write_then_read_above)
-add_test_case(test_http_connection_monitor_below_but_undetectable)
-add_test_case(test_http_connection_monitor_rw_below)
-add_test_case(test_http_connection_monitor_below_then_above)
-add_test_case(test_http_connection_monitor_failure_reset_when_empty)
-
-add_test_case(test_http_connection_monitor_bytes_overflow)
-add_test_case(test_http_connection_monitor_time_overflow)
-add_test_case(test_http_connection_monitor_shutdown)
-
-add_test_case(test_http_stats_trivial)
-add_test_case(test_http_stats_basic_request)
-add_test_case(test_http_stats_split_across_gather_boundary)
-add_test_case(test_http_stats_pipelined)
-add_test_case(test_http_stats_multiple_requests_with_gap)
+add_test_case(http_forwarding_proxy_connection_proxy_target)
+add_test_case(http_forwarding_proxy_connection_channel_failure)
+add_test_case(http_forwarding_proxy_connection_connect_failure)
+add_test_case(http_forwarding_proxy_request_transform)
+add_test_case(http_forwarding_proxy_request_transform_basic_auth)
+add_test_case(http_forwarding_proxy_request_transform_legacy_basic_auth)
+add_test_case(http_proxy_request_transform_kerberos)
+add_test_case(http_proxy_kerberos_token_failure)
+add_test_case(http_proxy_kerberos_connect_failure)
+add_test_case(http_proxy_adaptive_identity_success)
+add_test_case(http_proxy_adaptive_kerberos_success)
+add_test_case(http_proxy_adaptive_ntlm_success)
+add_test_case(http_proxy_adaptive_failure)
+add_test_case(http_forwarding_proxy_uri_rewrite)
+add_test_case(http_forwarding_proxy_uri_rewrite_options_star)
+add_test_case(http_tunnel_proxy_connection_success)
+add_test_case(https_tunnel_proxy_connection_success)
+add_test_case(http_tunnel_proxy_connection_failure_connect)
+add_test_case(https_tunnel_proxy_connection_failure_connect)
+add_test_case(https_tunnel_proxy_connection_failure_tls)
+
+add_test_case(http_connection_monitor_options_is_valid)
+add_test_case(http_connection_monitor_rw_above)
+add_test_case(http_connection_monitor_r_above)
+add_test_case(http_connection_monitor_w_above)
+add_test_case(http_connection_monitor_write_then_read_above)
+add_test_case(http_connection_monitor_below_but_undetectable)
+add_test_case(http_connection_monitor_rw_below)
+add_test_case(http_connection_monitor_below_then_above)
+add_test_case(http_connection_monitor_failure_reset_when_empty)
+
+add_test_case(http_connection_monitor_bytes_overflow)
+add_test_case(http_connection_monitor_time_overflow)
+add_test_case(http_connection_monitor_shutdown)
+
+add_test_case(http_stats_trivial)
+add_test_case(http_stats_basic_request)
+add_test_case(http_stats_split_across_gather_boundary)
+add_test_case(http_stats_pipelined)
+add_test_case(http_stats_multiple_requests_with_gap)
 
 # Tests that not make real connection but use TLS. So, still need to be marked as net test
 add_net_test_case(h2_sm_sanity_check)
@@ -680,12 +680,12 @@ if(ENABLE_LOCALHOST_INTEGRATION_TESTS)
     add_net_test_case(localhost_integ_h2_sm_connection_monitor_kill_slow_connection)
 endif()
 
-add_test_case(random_access_set_sanitize_test)
-add_test_case(random_access_set_insert_test)
-add_test_case(random_access_set_get_random_test)
-add_test_case(random_access_set_exist_test)
-add_test_case(random_access_set_remove_test)
-add_test_case(random_access_set_owns_element_test)
+add_test_case(random_access_set_sanitize)
+add_test_case(random_access_set_insert)
+add_test_case(random_access_set_get_random)
+add_test_case(random_access_set_exist)
+add_test_case(random_access_set_remove)
+add_test_case(random_access_set_owns_element)
 
 set(TEST_BINARY_NAME ${PROJECT_NAME}-tests)