Use new helpers in aws-c-common (#282)

* hex-to-num table moved to aws-c-common
* use new aws_string_new_from_cursor() helper fn

Author: graebm

source/connection.c

@@ -908,7 +908,7 @@ int aws_http_client_connect_internal(
     AWS_FATAL_ASSERT(options.proxy_options == NULL);
 
     /* bootstrap_new() functions requires a null-terminated c-str */
-    host_name = aws_string_new_from_array(options.allocator, options.host_name.ptr, options.host_name.len);
+    host_name = aws_string_new_from_cursor(options.allocator, &options.host_name);
     if (!host_name) {
         goto error;
     }

source/connection_manager.c

@@ -787,7 +787,7 @@ struct aws_http_connection_manager *aws_http_connection_manager_new(
     aws_linked_list_init(&manager->idle_connections);
     aws_linked_list_init(&manager->pending_acquisitions);
 
-    manager->host = aws_string_new_from_array(allocator, options->host.ptr, options->host.len);
+    manager->host = aws_string_new_from_cursor(allocator, &options->host);
     if (manager->host == NULL) {
         goto on_error;
     }

source/h2_decoder.c

@@ -1258,7 +1258,7 @@ static struct aws_h2err s_process_header_field(
         /* Buffer up pseudo-headers, we'll deliver them later once they're all validated. */
         current_block->pseudoheader_compression[pseudoheader_enum] = header_field->compression;
         current_block->pseudoheader_values[pseudoheader_enum] =
-            aws_string_new_from_array(decoder->alloc, header_field->value.ptr, header_field->value.len);
+            aws_string_new_from_cursor(decoder->alloc, &header_field->value);
         if (!current_block->pseudoheader_values[pseudoheader_enum]) {
             return aws_h2err_from_last_error();
         }

source/proxy_connection.c

@@ -71,7 +71,7 @@ struct aws_http_proxy_user_data *aws_http_proxy_user_data_new(
     user_data->state = AWS_PBS_SOCKET_CONNECT;
     user_data->error_code = AWS_ERROR_SUCCESS;
 
-    user_data->original_host = aws_string_new_from_array(allocator, options->host_name.ptr, options->host_name.len);
+    user_data->original_host = aws_string_new_from_cursor(allocator, &options->host_name);
     if (user_data->original_host == NULL) {
         goto on_error;
     }

source/request_response.c

@@ -343,7 +343,7 @@ static int s_set_string_from_cursor(
     /* If the cursor is empty, set dst to NULL */
     struct aws_string *new_str;
     if (cursor.len) {
-        new_str = aws_string_new_from_array(alloc, cursor.ptr, cursor.len);
+        new_str = aws_string_new_from_cursor(alloc, &cursor);
         if (!new_str) {
             return AWS_OP_ERR;
         }

source/strutil.c

@@ -4,32 +4,6 @@
  */
 #include <aws/http/private/strutil.h>
 
-/* Lookup from '0' -> 0, 'f' -> 0xf, 'F' -> 0xF, etc
- * invalid characters have value 255 */
-/* clang-format off */
-static const uint8_t s_ascii_to_num_table[256] = {
-    255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
-    255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
-    255, 255,
-    /* 0 - 9 */
-    0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
-    255, 255, 255, 255, 255, 255, 255,
-    /* A - F */
-    0xA, 0xB, 0xC, 0xD, 0xE, 0xF,
-    255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
-    255, 255, 255,
-    /* a - f */
-    0xa, 0xb, 0xc, 0xd, 0xe, 0xf,
-    255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
-    255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
-    255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
-    255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
-    255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
-    255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
-    255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
-};
-/* clang-format on */
-
 static int s_read_unsigned(struct aws_byte_cursor cursor, uint64_t *dst, uint8_t base) {
     uint64_t val = 0;
     *dst = 0;
@@ -38,10 +12,12 @@ static int s_read_unsigned(struct aws_byte_cursor cursor, uint64_t *dst, uint8_t
         return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
     }
 
+    const uint8_t *hex_to_num_table = aws_lookup_table_hex_to_num_get();
+
     /* read from left to right */
     for (size_t i = 0; i < cursor.len; ++i) {
         const uint8_t c = cursor.ptr[i];
-        const uint8_t cval = s_ascii_to_num_table[c];
+        const uint8_t cval = hex_to_num_table[c];
         if (cval >= base) {
             return aws_raise_error(AWS_ERROR_INVALID_ARGUMENT);
         }