Add Http Status Code and Header Utils

Removed private http status code definitions.
Added public http status code definitions and filled the list with common status codes.
Added aws_http_headers_has utils API to test if a header is in a header set.

Co-authored-by: singku <tangliang551@gmail.com>

Author: singku-china

include/aws/http/private/http_impl.h

@@ -43,19 +43,6 @@ enum aws_http_header_name {
     AWS_HTTP_HEADER_COUNT, /* Number of enums */
 };
 
-/**
- * Status codes that affect internal processing.
- * This is NOT a definitive list of codes.
- */
-enum aws_http_status {
-    AWS_HTTP_STATUS_UNKNOWN = -1, /* Invalid status code. Not using 0 because it's technically a legal value */
-    AWS_HTTP_STATUS_100_CONTINUE = 100,
-    AWS_HTTP_STATUS_101_SWITCHING_PROTOCOLS = 101,
-    AWS_HTTP_STATUS_200_OK = 200,
-    AWS_HTTP_STATUS_204_NO_CONTENT = 204,
-    AWS_HTTP_STATUS_304_NOT_MODIFIED = 304,
-};
-
 AWS_EXTERN_C_BEGIN
 
 AWS_HTTP_API void aws_http_fatal_assert_library_initialized(void);

include/aws/http/request_response.h

@@ -414,6 +414,12 @@ int aws_http_headers_get(
     struct aws_byte_cursor name,
     struct aws_byte_cursor *out_value);
 
+/**
+ * Test if header name exists or not in headers
+ */
+AWS_HTTP_API
+bool aws_http_headers_has(const struct aws_http_headers *headers, struct aws_byte_cursor name);
+
 /**
  * Remove all headers with this name.
  * AWS_ERROR_HTTP_HEADER_NOT_FOUND is raised if no headers with this name are found.

include/aws/http/status_code.h

@@ -0,0 +1,92 @@
+#ifndef AWS_HTTP_STATUS_CODE_H
+#define AWS_HTTP_STATUS_CODE_H
+
+/*
+ * Copyright 2010-2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License").
+ * You may not use this file except in compliance with the License.
+ * A copy of the License is located at
+ *
+ *  http://aws.amazon.com/apache2.0
+ *
+ * or in the "license" file accompanying this file. This file is distributed
+ * on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+ * express or implied. See the License for the specific language governing
+ * permissions and limitations under the License.
+ */
+
+/*
+ * Define most of the http response codes we probably will use.
+ * https://www.iana.org/assignments/http-status-codes/http-status-codes.txt
+ * This is NOT a definitive list of codes.
+ */
+enum aws_http_status_code {
+    /*
+     * This is a special response code defined for convenience in error processing,
+     * indicating processing of http request met error and didn't reach server.
+     */
+    AWS_HTTP_STATUS_CODE_UNKNOWN = -1,
+    AWS_HTTP_STATUS_CODE_100_CONTINUE = 100,
+    AWS_HTTP_STATUS_CODE_101_SWITCHING_PROTOCOLS = 101,
+    AWS_HTTP_STATUS_CODE_102_PROCESSING = 102,
+    AWS_HTTP_STATUS_CODE_103_EARLY_HINTS = 103,
+    AWS_HTTP_STATUS_CODE_200_OK = 200,
+    AWS_HTTP_STATUS_CODE_201_CREATED = 201,
+    AWS_HTTP_STATUS_CODE_202_ACCEPTED = 202,
+    AWS_HTTP_STATUS_CODE_203_NON_AUTHORITATIVE_INFORMATION = 203,
+    AWS_HTTP_STATUS_CODE_204_NO_CONTENT = 204,
+    AWS_HTTP_STATUS_CODE_205_RESET_CONTENT = 205,
+    AWS_HTTP_STATUS_CODE_206_PARTIAL_CONTENT = 206,
+    AWS_HTTP_STATUS_CODE_207_MULTI_STATUS = 207,
+    AWS_HTTP_STATUS_CODE_208_ALREADY_REPORTED = 208,
+    AWS_HTTP_STATUS_CODE_226_IM_USED = 226,
+    AWS_HTTP_STATUS_CODE_300_MULTIPLE_CHOICES = 300,
+    AWS_HTTP_STATUS_CODE_301_MOVED_PERMANENTLY = 301,
+    AWS_HTTP_STATUS_CODE_302_FOUND = 302,
+    AWS_HTTP_STATUS_CODE_303_SEE_OTHER = 303,
+    AWS_HTTP_STATUS_CODE_304_NOT_MODIFIED = 304,
+    AWS_HTTP_STATUS_CODE_305_USE_PROXY = 305,
+    AWS_HTTP_STATUS_CODE_307_TEMPORARY_REDIRECT = 307,
+    AWS_HTTP_STATUS_CODE_308_PERMANENT_REDIRECT = 308,
+    AWS_HTTP_STATUS_CODE_400_BAD_REQUEST = 400,
+    AWS_HTTP_STATUS_CODE_401_UNAUTHORIZED = 401,
+    AWS_HTTP_STATUS_CODE_402_PAYMENT_REQUIRED = 402,
+    AWS_HTTP_STATUS_CODE_403_FORBIDDEN = 403,
+    AWS_HTTP_STATUS_CODE_404_NOT_FOUND = 404,
+    AWS_HTTP_STATUS_CODE_405_METHOD_NOT_ALLOWED = 405,
+    AWS_HTTP_STATUS_CODE_406_NOT_ACCEPTABLE = 406,
+    AWS_HTTP_STATUS_CODE_407_PROXY_AUTHENTICATION_REQUIRED = 407,
+    AWS_HTTP_STATUS_CODE_408_REQUEST_TIMEOUT = 408,
+    AWS_HTTP_STATUS_CODE_409_CONFLICT = 409,
+    AWS_HTTP_STATUS_CODE_410_GONE = 410,
+    AWS_HTTP_STATUS_CODE_411_LENGTH_REQUIRED = 411,
+    AWS_HTTP_STATUS_CODE_412_PRECONDITION_FAILED = 412,
+    AWS_HTTP_STATUS_CODE_413_REQUEST_ENTITY_TOO_LARGE = 413,
+    AWS_HTTP_STATUS_CODE_414_REQUEST_URI_TOO_LONG = 414,
+    AWS_HTTP_STATUS_CODE_415_UNSUPPORTED_MEDIA_TYPE = 415,
+    AWS_HTTP_STATUS_CODE_416_REQUESTED_RANGE_NOT_SATISFIABLE = 416,
+    AWS_HTTP_STATUS_CODE_417_EXPECTATION_FAILED = 417,
+    AWS_HTTP_STATUS_CODE_421_MISDIRECTED_REQUEST = 421,
+    AWS_HTTP_STATUS_CODE_422_UNPROCESSABLE_ENTITY = 422,
+    AWS_HTTP_STATUS_CODE_423_LOCKED = 423,
+    AWS_HTTP_STATUS_CODE_424_FAILED_DEPENDENCY = 424,
+    AWS_HTTP_STATUS_CODE_425_TOO_EARLY = 425,
+    AWS_HTTP_STATUS_CODE_426_UPGRADE_REQUIRED = 426,
+    AWS_HTTP_STATUS_CODE_428_PRECONDITION_REQUIRED = 428,
+    AWS_HTTP_STATUS_CODE_429_TOO_MANY_REQUESTS = 429,
+    AWS_HTTP_STATUS_CODE_431_REQUEST_HEADER_FIELDS_TOO_LARGE = 431,
+    AWS_HTTP_STATUS_CODE_451_UNAVAILABLE_FOR_LEGAL_REASON = 451,
+    AWS_HTTP_STATUS_CODE_500_INTERNAL_SERVER_ERROR = 500,
+    AWS_HTTP_STATUS_CODE_501_NOT_IMPLEMENTED = 501,
+    AWS_HTTP_STATUS_CODE_502_BAD_GATEWAY = 502,
+    AWS_HTTP_STATUS_CODE_503_SERVICE_UNAVAILABLE = 503,
+    AWS_HTTP_STATUS_CODE_504_GATEWAY_TIMEOUT = 504,
+    AWS_HTTP_STATUS_CODE_505_HTTP_VERSION_NOT_SUPPORTED = 505,
+    AWS_HTTP_STATUS_CODE_506_VARIANT_ALSO_NEGOTIATES = 506,
+    AWS_HTTP_STATUS_CODE_507_INSUFFICIENT_STORAGE = 507,
+    AWS_HTTP_STATUS_CODE_508_LOOP_DETECTED = 508,
+    AWS_HTTP_STATUS_CODE_510_NOT_EXTENDED = 510,
+    AWS_HTTP_STATUS_CODE_511_NETWORK_AUTHENTICATION_REQUIRED = 511,
+};
+#endif /* AWS_HTTP_STATUS_CODE_H */

source/h1_connection.c

@@ -12,17 +12,17 @@
  * express or implied. See the License for the specific language governing
  * permissions and limitations under the License.
  */
-#include <aws/http/private/h1_connection.h>
-
 #include <aws/common/clock.h>
 #include <aws/common/math.h>
 #include <aws/common/mutex.h>
 #include <aws/common/string.h>
+#include <aws/http/private/h1_connection.h>
 #include <aws/http/private/h1_decoder.h>
 #include <aws/http/private/h1_encoder.h>
 #include <aws/http/private/h1_stream.h>
 #include <aws/http/private/request_response_impl.h>
 #include <aws/http/statistics.h>
+#include <aws/http/status_code.h>
 #include <aws/io/logging.h>
 
 #if _MSC_VER
@@ -988,9 +988,9 @@ static int s_decoder_on_header(const struct aws_h1_decoded_header *header, void
         /* Certain L7 proxies send a connection close header on a 200/OK response to a CONNECT request. This is nutty
          * behavior, but the obviously desired behavior on a 200 CONNECT response is to leave the connection open
          * for the tunneling. */
-        bool ignore_connection_close = incoming_stream->base.request_method == AWS_HTTP_METHOD_CONNECT &&
-                                       incoming_stream->base.client_data &&
-                                       incoming_stream->base.client_data->response_status == AWS_HTTP_STATUS_200_OK;
+        bool ignore_connection_close =
+            incoming_stream->base.request_method == AWS_HTTP_METHOD_CONNECT && incoming_stream->base.client_data &&
+            incoming_stream->base.client_data->response_status == AWS_HTTP_STATUS_CODE_200_OK;
 
         if (!ignore_connection_close && aws_byte_cursor_eq_c_str_ignore_case(&header->value_data, "close")) {
             AWS_LOGF_TRACE(
@@ -1047,7 +1047,7 @@ static int s_mark_head_done(struct aws_h1_stream *incoming_stream) {
 
         /* Only clients can receive informational headers.
          * Check whether we're switching protocols */
-        if (incoming_stream->base.client_data->response_status == AWS_HTTP_STATUS_101_SWITCHING_PROTOCOLS) {
+        if (incoming_stream->base.client_data->response_status == AWS_HTTP_STATUS_CODE_101_SWITCHING_PROTOCOLS) {
 
             /* Switching protocols while there are multiple streams is too complex to deal with.
              * Ensure stream_list has exactly this 1 stream in it. */

source/h1_decoder.c

@@ -13,10 +13,10 @@
  * permissions and limitations under the License.
  */
 
-#include <aws/http/private/h1_decoder.h>
-
 #include <aws/common/string.h>
+#include <aws/http/private/h1_decoder.h>
 #include <aws/http/private/strutil.h>
+#include <aws/http/status_code.h>
 #include <aws/io/logging.h>
 
 AWS_STATIC_STRING_FROM_LITERAL(s_transfer_coding_chunked, "chunked");
@@ -686,8 +686,8 @@ static int s_linestate_response(struct aws_h1_decoder *decoder, struct aws_byte_
     int code_val = (int)code_val_u64;
 
     /* RFC-7230 section 3.3 Message Body */
-    decoder->body_headers_ignored |= code_val == AWS_HTTP_STATUS_304_NOT_MODIFIED;
-    decoder->body_headers_forbidden = code_val == AWS_HTTP_STATUS_204_NO_CONTENT || code_val / 100 == 1;
+    decoder->body_headers_ignored |= code_val == AWS_HTTP_STATUS_CODE_304_NOT_MODIFIED;
+    decoder->body_headers_forbidden = code_val == AWS_HTTP_STATUS_CODE_204_NO_CONTENT || code_val / 100 == 1;
 
     if (s_check_info_response_status_code(code_val)) {
         decoder->header_block = AWS_HTTP_HEADER_BLOCK_INFORMATIONAL;

source/h1_encoder.c

@@ -13,8 +13,8 @@
  * permissions and limitations under the License.
  */
 #include <aws/http/private/h1_encoder.h>
-
 #include <aws/http/private/strutil.h>
+#include <aws/http/status_code.h>
 #include <aws/io/logging.h>
 #include <aws/io/stream.h>
 
@@ -230,8 +230,8 @@ int aws_h1_encoder_message_init_from_response(
      * no body needed in the response
      * RFC-7230 section 3.3 Message Body
      */
-    body_headers_ignored |= status_int == AWS_HTTP_STATUS_304_NOT_MODIFIED;
-    bool body_headers_forbidden = status_int == AWS_HTTP_STATUS_204_NO_CONTENT || status_int / 100 == 1;
+    body_headers_ignored |= status_int == AWS_HTTP_STATUS_CODE_304_NOT_MODIFIED;
+    bool body_headers_forbidden = status_int == AWS_HTTP_STATUS_CODE_204_NO_CONTENT || status_int / 100 == 1;
     err = s_scan_outgoing_headers(message, response, &header_lines_len, body_headers_ignored, body_headers_forbidden);
     if (err) {
         goto error;

source/h1_stream.c

@@ -12,9 +12,9 @@
  * express or implied. See the License for the specific language governing
  * permissions and limitations under the License.
  */
-#include <aws/http/private/h1_stream.h>
-
 #include <aws/http/private/connection_impl.h>
+#include <aws/http/private/h1_stream.h>
+#include <aws/http/status_code.h>
 
 #include <aws/io/logging.h>
 
@@ -96,7 +96,7 @@ struct aws_h1_stream *aws_h1_stream_new_request(
     }
 
     stream->base.client_data = &stream->base.client_or_server_data.client;
-    stream->base.client_data->response_status = AWS_HTTP_STATUS_UNKNOWN;
+    stream->base.client_data->response_status = AWS_HTTP_STATUS_CODE_UNKNOWN;
 
     /* Validate request and cache info that the encoder will eventually need */
     int err =