Fix conversion from size_t to uint32_t. #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanHenson
approved these changes
Oct 23, 2018
graebm
added a commit
that referenced
this pull request
Aug 16, 2024
**Issue #:** awslabs/aws-c-common#973 **Research:** 6 years ago, PR #5 made these constants `uint32_t` via a cast. **Description of changes:** Avoid `-Wuseless-cast` warnings, don't cast `size_t` to `uint32_t` on 32-bit platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Recent
Wconversionwill break the code because of failure to convert fromsize_ttouint32_t.aws-c-event-stream/source/event_stream.c
Line 407 in 920c4f3
This PR will define constants as
uint32_tto fix that.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.