Fix issue #15 by fixing aws-c-common installs #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`aws-c-event-stream` should not need to worry nor now how to find the `aws-c-common` CMake modules. This can be fixed by simply moving up `find_package(aws-c-common REQUIRED)` and making the `aws-c-common` package set the paths correctly. This has been confirmed to work on amazon linux 2. This commit requires awslabs/aws-c-common#587 to be merged first.
justinboswell
added
the
investigating
Contributor
|
Fixed by: #119 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aws-c-event-streamshould not need to worry nor now how to find theaws-c-commonCMake modules.This can be fixed by simply moving up
find_package(aws-c-common REQUIRED)and making theaws-c-commonpackage set the paths correctly.This has been confirmed to work on amazon linux 2.
This commit requires awslabs/aws-c-common#587 to be merged first.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.