-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK-Side: Query Passthrough Implementation #1769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chngpe
reviewed
Feb 22, 2024
AbdulR3hman
commented
Feb 22, 2024
chngpe
reviewed
Feb 22, 2024
...ration-sdk/src/main/java/com/amazonaws/athena/connector/lambda/metadata/GetTableRequest.java
Show resolved
Hide resolved
...hena/connector/lambda/metadata/optimizations/querypassthrough/QueryPassthroughSignature.java
Show resolved
Hide resolved
chngpe
reviewed
Feb 22, 2024
...eptune/src/test/java/com/amazonaws/athena/connectors/neptune/NeptuneMetadataHandlerTest.java
Outdated
Show resolved
Hide resolved
AbdulR3hman
force-pushed
the
qpt-sdk-changes
branch
from
February 22, 2024 23:52
78960ed
to
112e1dc
Compare
chngpe
reviewed
Feb 23, 2024
...on-sdk/src/main/java/com/amazonaws/athena/connector/lambda/domain/predicate/Constraints.java
Show resolved
Hide resolved
AbdulR3hman
force-pushed
the
qpt-sdk-changes
branch
from
February 23, 2024 15:34
e985833
to
32eec20
Compare
chngpe
approved these changes
Feb 23, 2024
burhan94
requested changes
Feb 23, 2024
athena-federation-sdk/src/main/java/com/amazonaws/athena/connector/lambda/domain/Split.java
Show resolved
Hide resolved
...ration-sdk/src/main/java/com/amazonaws/athena/connector/lambda/metadata/GetTableRequest.java
Outdated
Show resolved
Hide resolved
AbdulR3hman
force-pushed
the
qpt-sdk-changes
branch
2 times, most recently
from
February 23, 2024 20:36
c27b1ce
to
2da2301
Compare
burhan94
requested changes
Feb 23, 2024
...ration-sdk/src/main/java/com/amazonaws/athena/connector/lambda/metadata/GetTableRequest.java
Outdated
Show resolved
Hide resolved
...ration-sdk/src/main/java/com/amazonaws/athena/connector/lambda/metadata/GetTableRequest.java
Outdated
Show resolved
Hide resolved
rebased through CLI; it will re-run the checks. |
AbdulR3hman
force-pushed
the
qpt-sdk-changes
branch
from
February 23, 2024 20:46
2da2301
to
65b04e1
Compare
burhan94
approved these changes
Feb 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
- SDK-Side: Query Passthrough Implementation (#1769) - single split for snowflake (#1768) - make vpc optional in snowflake template (#1771) - build(deps): bump com.amazon.redshift:redshift-jdbc42 from 2.1.0.25 to 2.1.0.26 (#1763) - build(deps): bump com.amazon.redshift:redshift-jdbc42 - build(deps): bump org.postgresql:postgresql from 42.7.1 to 42.7.2 in /athena-postgresql (#1766) - build(deps): bump org.postgresql:postgresql in /athena-postgresql - Disable map support (#1765) - Support map of complex types (#1764) - build(deps): bump net.sf.jt400:jt400 from 20.0.6 to 20.0.7 (#1760) - build(deps): bump net.sf.jt400:jt400 from 20.0.6 to 20.0.7 - build(deps): bump com.google.cloud:google-cloud-storage from 2.33.0 to 2.34.0 (#1761) - build(deps): bump com.google.cloud:google-cloud-storage - build(deps): bump aws-sdk.version from 1.12.656 to 1.12.661 (#1758) - build(deps): bump aws-sdk.version from 1.12.656 to 1.12.661 - build(deps): bump com.google.protobuf:protobuf-java from 3.25.2 to 3.25.3 (#1757) - build(deps): bump com.google.protobuf:protobuf-java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query Passthrough (QPT)
These changes will allow the connector to extend query passthrough functionality, and provide an interface to define QPT signature per connector.