Adding null check for error code #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing null pointer exception which is occurs when error code is null. This cause original exception to be lost.
Issue #, if available:
Description of changes:
Adding null check for
errorCode
in the methoderrorCode
ofAmazonSQSMessagingClientWrapper
. MethodisJMSSecurityException
checks in the SetSECURITY_EXCEPTION_ERROR_CODES
for presence of error code. Set internally calls Objects.requireNonNull which throws Null pointer exception Ref: https://github.com/corretto/corretto-17/blob/4806b202a348e6344c84a89ea23eef026788126a/src/java.base/share/classes/java/util/Objects.java#L209.This causes original exception to be lost and it never gets reported. Below is an example stacktrace where due to proxy auth issue (Service returned HTTP status code 407 (Service: Sqs, Status Code: 407, Request ID: null)) lib reported null pointer instead of original error:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.