Skip to content

Commit 41aaf19

Browse files
committed
Tweak logging statement levels
At present, for every JMS message sent there are the following 2 statements logged at info level: - messageId in SQSMessageProducer#sendInternal - shutting down executor in SQSSession#doClose These result in excessive logging for systems that product a lot of JMS messages and are really better fit for debug level. Additionally, SQSMessageConsumer#doClose also has an equivalent logging statement to one in SQSSession#doClose. Finally, SQSSessionCallbackScheduler#run contains logging statement that logs exception at info level, which is better suited for warn level.
1 parent caea19d commit 41aaf19

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

src/main/java/com/amazon/sqs/javamessaging/SQSMessageConsumer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ void doClose() {
224224

225225
try {
226226
if (!prefetchExecutor.isShutdown()) {
227-
LOG.info("Shutting down {} executor", SQSSession.CONSUMER_PREFETCH_EXECUTOR_NAME);
227+
LOG.debug("Shutting down {} executor", SQSSession.CONSUMER_PREFETCH_EXECUTOR_NAME);
228228
// Shut down executor.
229229
prefetchExecutor.shutdown();
230230
}

src/main/java/com/amazon/sqs/javamessaging/SQSMessageProducer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ void sendInternal(SQSQueueDestination queue, Message rawMessage) throws JMSExcep
152152

153153
SendMessageResponse sendMessageResult = amazonSQSClient.sendMessage(sendMessageRequest.build());
154154
String messageId = sendMessageResult.messageId();
155-
LOG.info("Message sent to SQS with SQS-assigned messageId: {}", messageId);
155+
LOG.debug("Message sent to SQS with SQS-assigned messageId: {}", messageId);
156156
// TODO: Do not support disableMessageID for now.
157157
message.setSQSMessageId(messageId);
158158

src/main/java/com/amazon/sqs/javamessaging/SQSSession.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ void doClose() throws JMSException {
405405

406406
try {
407407
if (executor != null) {
408-
LOG.info("Shutting down {} executor", SESSION_EXECUTOR_NAME);
408+
LOG.debug("Shutting down {} executor", SESSION_EXECUTOR_NAME);
409409

410410
executor.shutdown();
411411

src/main/java/com/amazon/sqs/javamessaging/SQSSessionCallbackScheduler.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ public void run() {
143143
try {
144144
messageListener.onMessage(message);
145145
} catch (Throwable ex) {
146-
LOG.info("Exception thrown from onMessage callback for message {}",
146+
LOG.warn("Exception thrown from onMessage callback for message {}",
147147
message.getSQSMessageId(), ex);
148148
callbackFailed = true;
149149
} finally {

0 commit comments

Comments
 (0)