Updated README #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-ordered sections Added S3 storage configuration options Added SNS to SQS code sample
aws-rizi
suggested changes
Aug 4, 2020
aws-rizi
suggested changes
Aug 7, 2020
| @@ -1,11 +1,8 @@ | |||
| ## Amazon SNS Extended Client Library for Java | |||
There was a problem hiding this comment.
Not related to read me, but I got a comment here :
#1 (comment)
coulaudf
Since right now the extended client only supports SQS I think we should make this clear in the java doc. In the future, when we support other endpoint we may update the documentation.
She suggested to reach out to you for a better java doc for that method. Could you please take a look and let me know what is the best comment for that?
Thanks a lot.
aws-rizi
suggested changes
Aug 10, 2020
…use publish(String, String)
aws-rizi
suggested changes
Aug 12, 2020
Addressed latest comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-ordered sections
Added S3 storage configuration options
Added SNS to SQS code sample
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.