Skip to content

Commit 5a2f60c

Browse files
committed
Address comments
1 parent 0684545 commit 5a2f60c

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

src/source/Ice/IceAgent.c

+4-2
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ STATUS iceAgentAddRemoteCandidate(PIceAgent pIceAgent, PCHAR pIceCandidateString
327327
PDoubleListNode pCurNode = NULL;
328328
SDP_ICE_CANDIDATE_PARSER_STATE state;
329329
ICE_CANDIDATE_TYPE iceCandidateType = ICE_CANDIDATE_TYPE_HOST;
330-
CHAR remoteProtocol[MAX_PROTOCOL_LENGTH];
330+
CHAR remoteProtocol[MAX_PROTOCOL_LENGTH] = {'\0'};
331331

332332
CHK(pIceAgent != NULL && pIceCandidateString != NULL, STATUS_NULL_ARG);
333333
CHK(!IS_EMPTY_STRING(pIceCandidateString), STATUS_INVALID_ARG);
@@ -355,7 +355,9 @@ STATUS iceAgentAddRemoteCandidate(PIceAgent pIceAgent, PCHAR pIceCandidateString
355355
STRTOUI32(curr, next, 10, &priority);
356356
break;
357357
case SDP_ICE_CANDIDATE_PARSER_STATE_PROTOCOL:
358-
STRNCPY(remoteProtocol, curr, tokenLen);
358+
if(tokenLen < MAX_PROTOCOL_LENGTH) {
359+
STRNCPY(remoteProtocol, curr, tokenLen);
360+
}
359361
CHK(STRNCMPI("tcp", curr, tokenLen) != 0, STATUS_ICE_CANDIDATE_STRING_IS_TCP);
360362
break;
361363
case SDP_ICE_CANDIDATE_PARSER_STATE_IP:

0 commit comments

Comments
 (0)