Skip to content

Commit 4635b64

Browse files
authored
Fix Windows tests (#1769)
* enable verbose logs * fix syntax * without gtest filter * env path * cmd.exe /c * give permissions to file * move to C: instead of D: * don't move anything * add paths to pthread, ssl, crypto, websockets dlls * cd missing * uncomment other builds * comment msan * filter out tests
1 parent 863a1a4 commit 4635b64

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

.github/build_windows_openssl.bat

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvars64.bat"
1+
call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x86_amd64
22
mkdir build
33
cd build
44
cmd.exe /c cmake -G "NMake Makefiles" ..

.github/workflows/ci.yml

+9-10
Original file line numberDiff line numberDiff line change
@@ -345,17 +345,15 @@ jobs:
345345
windows-msvc-openssl:
346346
runs-on: windows-2022
347347
env:
348-
AWS_KVS_LOG_LEVEL: 7
348+
AWS_KVS_LOG_LEVEL: 1
349349
steps:
350350
- name: Clone repository
351351
uses: actions/checkout@v3
352352
- name: Move cloned repo
353353
shell: powershell
354354
run: |
355-
mkdir D:\a\webrtc
356-
Move-Item -Path "D:\a\amazon-kinesis-video-streams-webrtc-sdk-c\amazon-kinesis-video-streams-webrtc-sdk-c\*" -Destination "D:\a\webrtc"
357-
cd D:\a\webrtc
358-
dir
355+
mkdir C:\webrtc
356+
Move-Item -Path "D:\a\amazon-kinesis-video-streams-webrtc-sdk-c\amazon-kinesis-video-streams-webrtc-sdk-c\*" -Destination "C:\webrtc"
359357
- name: Install dependencies
360358
shell: powershell
361359
run: |
@@ -380,13 +378,14 @@ jobs:
380378
- name: Build repository
381379
shell: powershell
382380
run: |
383-
cd D:\a\webrtc
381+
cd C:\webrtc
384382
git config --system core.longpaths true
385383
.github\build_windows_openssl.bat
386-
# TODO: Fix these tests
387-
# - name: Run tests
388-
# run: |
389-
# & "D:\a\webrtc\build\tst\webrtc_client_test.exe --gtest_filter='-DataChannelFunctionalityTest.*:IceApiTest.*:IceFunctionalityTest.*:PeerConnectionFunctionalityTest.*:SignalingApiFunctionalityTest.*:TurnConnectionFunctionalityTest.*:RtpFunctionalityTest.marshallUnmarshallH264Data:RtpFunctionalityTest.packingUnpackingVerifySameH264Frame:RtcpFunctionalityTest.onRtcpPacketCompound:RtcpFunctionalityTest.twcc3'"
384+
- name: Run tests
385+
shell: powershell
386+
run: |
387+
$env:Path += ';C:\webrtc\open-source\bin;C:\tools\pthreads-w32-2-9-1-release\Pre-built.2\dll\x64'
388+
& "C:\webrtc\build\tst\webrtc_client_test.exe" --gtest_filter="-DataChannelFunctionalityTest.*:IceApiTest.*:IceFunctionalityTest.*:PeerConnectionFunctionalityTest.*:SignalingApiFunctionalityTest.*:TurnConnectionFunctionalityTest.*:RtpFunctionalityTest.marshallUnmarshallH264Data:RtpFunctionalityTest.packingUnpackingVerifySameH264Frame:RtcpFunctionalityTest.onRtcpPacketCompound:RtcpFunctionalityTest.twcc3"
390389
# windows-msvc-mbedtls:
391390
# runs-on: windows-2022
392391
# env:

0 commit comments

Comments
 (0)