Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install awscli v2 bundle when possible #1066

Merged
merged 4 commits into from
Nov 9, 2022
Merged

Install awscli v2 bundle when possible #1066

merged 4 commits into from
Nov 9, 2022

Conversation

cartermckinnon
Copy link
Member

@cartermckinnon cartermckinnon commented Oct 28, 2022

Description of changes:

This installs the latest awscli v2 bundle when possible, as the version available in the AL yum repos generally lags behind. It also includes the version of the awscli in the binaries section of the version-info.json file, because the bundle wouldn't appear in the packages section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

In us-west-2, I can see that the v2 bundle is installed:

> make 1.22
...
2022-10-28T08:54:58-07:00:     amazon-ebs: Installing awscli v2 bundle
2022-10-28T08:55:03-07:00:     amazon-ebs: You can now run: /usr/local/bin/aws --version
...

and the version is present in version-info.json:

> jq .binaries.awscli amazon-eks-node-1.22-v20221028-version-info.json 
"2.8.6"

scripts/install-worker.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmerkes mmerkes merged commit 794ed5f into master Nov 9, 2022
@cartermckinnon cartermckinnon deleted the awscli-update branch November 9, 2022 23:27
@guessi
Copy link
Member

guessi commented Nov 17, 2022

For anyone who found that $sudo aws don't work after updating node to v20221112 or later version,

$ sudo aws --version
sudo: aws: command not found

I'm here to address the change of aws command, see the discussion here.

If you need to execute aws command somewhere in your bootstrap script (or manual exection), please update your command to sudo /usr/local/bin/aws ... when you calling aws with sudo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants