Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(maintenance): add overwrite to artifact arn in layer pipeline #1970

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

This PR applies the change recommended in the actions/upload-artifact migration guide. As part of the new version the action treats artifacts as immutable, however in our layers workflow we intentionally upload an artifact with the same name.

This PR sets the overwrite: true flag to revert to v3 behavior.

Related issues, RFCs

Issue number: #1966

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi requested a review from a team as a code owner January 25, 2024 15:19
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Jan 25, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jan 25, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dreamorosi dreamorosi merged commit 9aa68bf into main Jan 25, 2024
14 checks passed
@dreamorosi dreamorosi deleted the chore/handle_double_artifact_layers branch January 25, 2024 15:29
@dreamorosi dreamorosi linked an issue Jan 26, 2024 that may be closed by this pull request
2 tasks
@dreamorosi dreamorosi self-assigned this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: update layers workflow to properly manage artifacts
2 participants