fix(idempotency): skip persistence for optional idempotency key#1507
Merged
am29d merged 9 commits intoaws-powertools:mainfrom Jun 20, 2023
am29d:1501-no-op-missing-idempotency-key
Merged
fix(idempotency): skip persistence for optional idempotency key#1507am29d merged 9 commits intoaws-powertools:mainfrom am29d:1501-no-op-missing-idempotency-key
am29d merged 9 commits intoaws-powertools:mainfrom
am29d:1501-no-op-missing-idempotency-key
Conversation
dreamorosi
reviewed
Jun 16, 2023
dreamorosi
reviewed
Jun 16, 2023
dreamorosi
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have implemented a skip step within
IdempotencyHandlerinstead ofBasePersistenceLayer. The reason for that was to skip the flow as early as possible and avoid any additional overhead on IdempotencyRecord computation. The downside is now the same functionality needs to be ported to the middy implementation, because it does not reuse theIdempotencyHandlerlogic.I am don't like the solution, though it solve the problem for now. I think we should refactor the
IdempotencyHandlerto suite the middy implementation and have one control flow. Open to any suggestion, if there is another way to handle that. The skip step feels like an additional middleware step we can attach to the idempotency, but I lack deeper middy knowledge how we could chain it transparently.Related issues, RFCs
Issue number: #1501
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.