Skip to content

feat(idempotency): support dataclasses & pydantic models payloads #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions aws_lambda_powertools/utilities/idempotency/persistence/base.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""
Persistence layers supporting idempotency
"""

import datetime
import hashlib
import json
Expand Down Expand Up @@ -105,6 +104,21 @@ def response_json_as_dict(self) -> dict:
return json.loads(self.response_data)


def _prepare_data(data: Any) -> Any:
# Convert pydantic as a dict
_dict = getattr(data, "dict", None)
if callable(_dict):
return _dict()

# Convert dataclasses as a dict
if hasattr(data, "__dataclass_fields__"):
import dataclasses

return dataclasses.asdict(data)

return getattr(data, "raw_event", data)


class BasePersistenceLayer(ABC):
"""
Abstract Base Class for Idempotency persistence layer.
Expand Down Expand Up @@ -226,8 +240,7 @@ def _generate_hash(self, data: Any) -> str:
Hashed representation of the provided data

"""
data = getattr(data, "raw_event", data) # could be a data class depending on decorator order
hashed_data = self.hash_function(json.dumps(data, cls=Encoder, sort_keys=True).encode())
hashed_data = self.hash_function(json.dumps(_prepare_data(data), cls=Encoder, sort_keys=True).encode())
return hashed_data.hexdigest()

def _validate_payload(self, data: Dict[str, Any], data_record: DataRecord) -> None:
Expand Down
34 changes: 33 additions & 1 deletion tests/functional/idempotency/test_idempotency.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
IdempotencyValidationError,
)
from aws_lambda_powertools.utilities.idempotency.idempotency import idempotent, idempotent_function
from aws_lambda_powertools.utilities.idempotency.persistence.base import BasePersistenceLayer, DataRecord
from aws_lambda_powertools.utilities.idempotency.persistence.base import BasePersistenceLayer, DataRecord, _prepare_data
from aws_lambda_powertools.utilities.validation import envelopes, validator
from tests.functional.idempotency.conftest import serialize
from tests.functional.utils import load_event
Expand Down Expand Up @@ -1057,3 +1057,35 @@ def two(data):
assert one(data=mock_event) == "one"
assert two(data=mock_event) == "two"
assert len(persistence_store.table.method_calls) == 4


def test_idempotent_function_dataclasses():
try:
# Scenario _prepare_data should allow for python dataclasses
from dataclasses import asdict, dataclass

@dataclass
class Foo:
name: str

data = Foo(name="Bar")
as_dict = _prepare_data(data)
assert asdict(data) == as_dict
assert as_dict == {"name": "Bar"}

except ModuleNotFoundError:
# Python 3.6
pass


def test_idempotent_function_pydantic():
# Scenario _prepare_data should allow for pydantic
from pydantic import BaseModel

class Foo(BaseModel):
name: str

data = Foo(name="Bar")
as_dict = _prepare_data(data)
assert as_dict == data.dict()
assert as_dict == {"name": "Bar"}