fix(parameters): fix variable shadowing in SSM parameter chunking#8006
Merged
dreamorosi merged 1 commit intodevelopfrom Feb 25, 2026
Merged
fix(parameters): fix variable shadowing in SSM parameter chunking#8006dreamorosi merged 1 commit intodevelopfrom
dreamorosi merged 1 commit intodevelopfrom
Conversation
Fixes bug where get_parameters_by_name returned only the last chunk when fetching more than 10 parameters due to variable shadowing in _get_parameters_by_name_in_chunks loop. Closes #7832
pull-request-size
bot
added
the
size/S
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: closes #7832
Summary
Changes
Fixed variable shadowing bug in
_get_parameters_by_name_in_chunkswhere theresponsevariable was being overwritten on each loop iteration instead of accumulating results from all chunks.response, possible_errors = self._get_parameters_by_name(...)tochunk_response, possible_errors = self._get_parameters_by_name(...)response.update(response)toresponse.update(chunk_response)User experience
Before: When calling
get_parameters_by_namewith more than 10 parameters, only the last chunk (up to 10 parameters) was returned.After: All requested parameters are correctly returned regardless of batch size.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.