Skip to content

Conversation

@DanyC97
Copy link
Contributor

@DanyC97 DanyC97 commented Sep 30, 2021

Issue #, if available: #684

Description of changes:

Currently the documentation provides example of installing the deploying
the SAR app using various frameworks.

This commit extend the list by providing a Terraform example.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


View rendered docs/index.md

Currently the documentation provides example of installing the deploying
the SAR app using various frameworks.

This commit extend the list by providing a Terraform example.
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 30, 2021
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Sep 30, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 30, 2021

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.

@heitorlessa
Copy link
Contributor

Looking at it now ;)

Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
@heitorlessa heitorlessa linked an issue Oct 1, 2021 that may be closed by this pull request
@heitorlessa heitorlessa changed the title docs: Install the lambda SAR layer using Terraform docs: Terraform reference for SAR Lambda Layer Oct 1, 2021
@heitorlessa heitorlessa merged commit 68c810e into aws-powertools:develop Oct 1, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 1, 2021

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@heitorlessa
Copy link
Contributor

As said on Slack, thank you so much @DanyC97 for taking the time ;)

heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Oct 1, 2021
…tools-python into develop

* 'develop' of https://github.com/awslabs/aws-lambda-powertools-python:
  docs: Terraform reference for SAR Lambda Layer (aws-powertools#716)
  chore(deps-dev): bump flake8-bugbear from 21.9.1 to 21.9.2 (aws-powertools#712)
  chore(deps): bump boto3 from 1.18.49 to 1.18.51 (aws-powertools#713)
  chore(deps): bump boto3 from 1.18.41 to 1.18.49 (aws-powertools#703)
  chore(deps): bump codecov/codecov-action from 2.0.2 to 2.1.0 (aws-powertools#675)
@DanyC97
Copy link
Contributor Author

DanyC97 commented Oct 1, 2021

As said on Slack, thank you so much @DanyC97 for taking the time ;)

is my pleasure @heitorlessa , will try to slowly get involved more

@DanyC97 DanyC97 deleted the fix-684-terraform-docs-example branch October 1, 2021 12:18
heitorlessa added a commit to gwlester/aws-lambda-powertools-python that referenced this pull request Oct 1, 2021
* develop:
  feat(feature-flags): improve "IN/NOT_IN"; new rule actions (aws-powertools#710)
  feat(idempotency): makes customers unit testing easier (aws-powertools#719)
  feat(feature-flags): get_raw_configuration property in Store (aws-powertools#720)
  feat: boto3 sessions in batch, parameters & idempotency (aws-powertools#717)
  feat: add get_raw_configuration property in store; expose store
  fix(mypy): a few return types, type signatures, and untyped areas (aws-powertools#718)
  docs: Terraform reference for SAR Lambda Layer (aws-powertools#716)
  chore(deps-dev): bump flake8-bugbear from 21.9.1 to 21.9.2 (aws-powertools#712)
  chore(deps): bump boto3 from 1.18.49 to 1.18.51 (aws-powertools#713)
  fix(idempotency): sorting keys before hashing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs - add TF deployment snippet

2 participants