-
Notifications
You must be signed in to change notification settings - Fork 428
fix(api_gateway): allow whitespace in routes' path parameter #1099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
Codecov Report
@@ Coverage Diff @@
## develop #1099 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 119 119
Lines 5378 5378
Branches 613 613
========================================
Hits 5376 5376
Partials 2 2
Continue to review full report at Codecov.
|
@sthuber90 Mind creating a separate test out the tests? So there's a separate test for whitespace checks? Want to make sure that the tests are easy to spot if we get a regression in the future |
Sure, will do |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
…ertools#1099) Co-authored-by: Heitor Lessa <lessa@amazon.co.uk>
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: fix(api_gateway): allow whitespace in routes' path parameter (aws-powertools#1099)
Issue number: #1098
Summary
Changes
Updated the
_UNSAFE_URI
constant to support whitespace in path parameterUser experience
User facing nothing changed
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.