fix: Allow empty responses as well as null response in AppConfig#1673
Merged
jeromevdl merged 1 commit intoaws-powertools:mainfrom Aug 20, 2024
Merged
Conversation
jeromevdl
reviewed
Aug 2, 2024
...parameters/src/main/java/software/amazon/lambda/powertools/parameters/AppConfigProvider.java
Outdated
Show resolved
Hide resolved
jeromevdl
suggested changes
Aug 2, 2024
Contributor
jeromevdl
left a comment
jeromevdl
left a comment
There was a problem hiding this comment.
Almost OK for me, please remove the unused import
- AppConfig responses, where config hasn't changed, seem to be result in "empty" `SdkBytes` objects rather than `null` `Configuration` in the response.
chrisclayson
force-pushed
the
fix-app-config-fetch-empty
branch
from
998188c to
6554f3e
Compare
|
jeromevdl
approved these changes
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1673 +/- ##
============================================
+ Coverage 79.07% 79.17% +0.10%
- Complexity 754 755 +1
============================================
Files 93 93
Lines 2877 2877
Branches 307 307
============================================
+ Hits 2275 2278 +3
+ Misses 503 501 -2
+ Partials 99 98 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1672
Description of changes:
When checking for empty response from AWS AppConfig data plane, check whether response is an empty byte array rather as well as
null.Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.