Skip to content

fix: Metrics e2e tests #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Mar 3, 2025

Please provide the issue number

Issue number: #796

Summary

Changes

correct command in e2e-tests.yml and remove unnecessary assertions in FunctionTests.cs

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig March 3, 2025 11:55
@boring-cyborg boring-cyborg bot added github-actions Changes in GitHub workflows internal Maintenance changes tests labels Mar 3, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2025
@hjgraca hjgraca linked an issue Mar 3, 2025 that may be closed by this pull request
1 task
@github-actions github-actions bot added the bug Unexpected, reproducible and unintended software behaviour label Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.04%. Comparing base (ef48a94) to head (7a0e0d9).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #802      +/-   ##
===========================================
+ Coverage    74.01%   74.04%   +0.02%     
===========================================
  Files          210      210              
  Lines         8402     8402              
  Branches       910      910              
===========================================
+ Hits          6219     6221       +2     
+ Misses        1884     1883       -1     
+ Partials       299      298       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Mar 3, 2025

@hjgraca hjgraca merged commit 98b19d3 into aws-powertools:develop Mar 3, 2025
10 checks passed
@hjgraca hjgraca deleted the fix/metrics-e2e-tests branch March 3, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected, reproducible and unintended software behaviour github-actions Changes in GitHub workflows internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Metrics v2 - fix e2e tests
2 participants