Skip to content

chore: add Logging Service property priority to docs #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jan 28, 2025

Please provide the issue number

Issue number: #702

Summary

Changes

Add Logging Service property priority to docs

Service Property Priority Resolution

The root level Service property now correctly follows this priority order:

  1. LoggingAttribute.Service (property value set in the decorator)
  2. POWERTOOLS_SERVICE_NAME (environment variable)

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
@auto-assign auto-assign bot requested review from amirkaws and sliedig January 28, 2025 10:29
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jan 28, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 28, 2025
@hjgraca hjgraca changed the title choreL add Logging Service property priority to docs chore: add Logging Service property priority to docs Jan 28, 2025
@github-actions github-actions bot added the internal Maintenance changes label Jan 28, 2025
@hjgraca hjgraca merged commit ff2403e into develop Jan 28, 2025
4 checks passed
@hjgraca hjgraca deleted the hjgraca-docs-service branch January 28, 2025 10:31
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal Maintenance changes size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants