-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning: ADOT Collector v0.35.0 breaking changes - Normalization of metrics in prometheus exporters #2367
Comments
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
This issue was closed because it has been marked as stale for 30 days with no activity. |
What is happening?
Starting with version v0.85.0 of the upstream OpenTelemetry collector, the normalization of metrics when converting from OpenTelemetry metrics to Prometheus will be enabled by default.
When will this happen?
The AWS Distro for OpenTelemetry (ADOT) collector will start adopting the upstream behavior for name normalization of Prometheus metrics on version v0.35.0.
Who is affected and what to expect?
You are affected if you are using one of the following components present in the ADOT collector: prometheus exporter and prometheus remote write exporter.
If you don’t do anything, the name of the metrics exported by the collector using these components will be normalized according to well defined rules [1,2]. These rules are applied so best practices are applied to the naming of metrics [3].
Notably the following changes will enter in effect:
_total
suffix.Examples:
The feature gate
pkg.translator.prometheus.NormalizeName
is used to control the normalization behavior. If the feature gate is disabled, there won’t be name normalization. Besides that, both components added a configuration option to control the normalization behaviour in the component level, theadd_metric_suffixes
property. This configuration option is only honoured if the feature gate is enabled.In the ADOT collector v0.34.0, the feature gate
pkg.translator.prometheus.NormalizeName
is disabled by default. In the collector v0.35.0, this feature gate will be enabled by default.What action items do I need to take?
If you want to upgrade to the ADOT collector v0.35.0 without name normalization
This path is recommended for users who want to retain the metrics names unchanged after upgrading to the ADOT collector v0.35.0. This will guarantee that dashboards and alarms remain functional after the upgrade.
The following step by step guide is provided to guarantee a safe and gradual migration.
Steps:
add_metric_suffixes: false
to the configuration section of these components.Example:
If you recently upgraded to ADOT collector v0.35.0
This path is recommended for users that are already using the ADOT collector v0.35.0. The following steps are recommended:
add_metric_suffixes: false
in the configuration section of these components.Example:
The text was updated successfully, but these errors were encountered: