Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSM and SecretsManager Config Variable support #1894

Closed
driverpt opened this issue Mar 3, 2023 · 11 comments
Closed

SSM and SecretsManager Config Variable support #1894

driverpt opened this issue Mar 3, 2023 · 11 comments
Assignees
Labels
ADOT collector ADOT Collector related issues feature-request Feature request stale

Comments

@driverpt
Copy link

driverpt commented Mar 3, 2023

Is your feature request related to a problem? Please describe.
We would like to run OTEL Collector as Lambda Layer but we need the External Provider Key to be injected from AWS SecretsManager.
The purpose is to prevent attaching Lambdas to VPC to avoid IP Exhaustion.

Describe the solution you'd like
Have a custom AWS Config Provider in OTEL Config, e.g.:

receivers:
    otlp:
      protocols:
        grpc:
        http:
    exporters:
      otlp/external_provider:
        endpoint: "<external_provider_url>"
        headers:
           api-key: ${secretsmanager:${env:SECRET_ARN}}
           compression: gzip
    processors:
    extensions:
    service:
      extensions: [zpages, memory_ballast]
      pipelines:
        traces:
          receivers: [otlp]
          processors: []
          exporters: [otlp/external_provider]

Describe alternatives you've considered
N/A

Additional context
External Providers as in DataDog, NewRelic, Splunk, etc.....

@mhausenblas mhausenblas self-assigned this Mar 3, 2023
@mhausenblas mhausenblas added feature-request Feature request ADOT collector ADOT Collector related issues labels Mar 3, 2023
@mhausenblas
Copy link
Member

Thank you, @driverpt and certainly something we can consider for 2023.

@driverpt
Copy link
Author

driverpt commented Mar 3, 2023

@mhausenblas , is it also possible to add AOT_CONFIG_CONTENT to Lambda?

Lambda doesn't have the ValueFrom thingy.

Ideally we would like to spin out an OTEL Collector the sameway as we do in ECS

@adrianpozueco
Copy link

would be really helpful

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label May 7, 2023
@driverpt
Copy link
Author

Not Stale

@github-actions github-actions bot removed the stale label May 14, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jul 16, 2023
@olegstanko
Copy link

I think it's work in progress according to the Roadmap :)

@mhausenblas mhausenblas removed the stale label Jul 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Oct 1, 2023
Copy link
Contributor

github-actions bot commented Nov 5, 2023

This issue was closed because it has been marked as stale for 30 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2023
@olegstanko
Copy link

I think it's in progress and can't be closed

@vasileh
Copy link

vasileh commented Jul 10, 2024

Regarding the secretsmanager scheme on the confmap, are there any plans to bring it live in the AWS Otel collector? I see the topic has been put on closed, but this feature is somehow not available. Thanks for your support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADOT collector ADOT Collector related issues feature-request Feature request stale
Development

No branches or pull requests

5 participants