Add descriptive error messages to custom sync fields #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedbackThomson
commented
Mar 22, 2022
| go 1.17 | ||
|
|
||
| replace github.com/aws-controllers-k8s/runtime => ../runtime | ||
|
|
Contributor
Author
There was a problem hiding this comment.
FYI this is a go.local.mod file - these changes were automatically assumed because of the newest runtime version.
Contributor
Author
|
This PR fixes aws-controllers-k8s/community#1206 |
Contributor
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaypipes, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Wraps all custom sync methods with error string describing what property threw the error. Also prevents
MethodNotAllowederrors returned byGutBucketAccelerateConfigurationfrom preventing reconciliation in opt-in regions.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.