Improve feature gate handling in config and runtime #162
Conversation
Improved the handling of feature gates in the `config` and `runtime` packages by updating the validation logic to properly handle errors when overriding feature gates. This patch also renams the `ReadOnly` featuregate to `ReadOnlyResources` to better describe its purpos.
a-hilaly
force-pushed
the
read-only-enhancements
branch
from
fd89f7e to
018e1c7
Compare
|
@a-hilaly: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, michaelhtm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…k8s#162) Improved the handling of feature gates in the `config` and `runtime` packages by updating the validation logic to properly handle errors when overriding feature gates. This patch also renams the `ReadOnly` featuregate to `ReadOnlyResources` to better describe its purpose. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Improved the handling of feature gates in the
configandruntimepackages by updating the validation logic to properly handle errors
when overriding feature gates.
This patch also renams the
ReadOnlyfeaturegate toReadOnlyResourcesto better describe its purpose.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.