temp

Author: michaelhtm

mocks/pkg/types/aws_resource_manager.go

@@ -332,7 +332,6 @@ func (r *resourceReconciler) handleAdoption(
 
 	rlog.Enter("rm.ReadOne")
 	latest, err := rm.ReadOne(ctx, resolved)
-	rm.FilterAWSTags(latest)
 	rlog.Exit("rm.ReadOne", err)
 	if err != nil {
 		return latest, err

pkg/runtime/reconciler.go

@@ -52,18 +52,18 @@ func Merge(a Tags, b Tags) Tags {
 	return result
 }
 
-// IgnoreAWSTags ignores tags that have keys that start with "aws:"
-// is needed to ensure the controller does not attempt to remove
-// tags set by AWS
-// Eg. resources created with cloudformation have tags that cannot be
-// removed by an ACK controller
-func IgnoreAWSTags(tags Tags) {
-	for k := range tags {
-		if strings.HasPrefix(k, "aws:") {
-			delete(tags, k)
-		}
-	}
-}
+// // IgnoreAWSTags ignores tags that have keys that start with "aws:"
+// // is needed to ensure the controller does not attempt to remove
+// // tags set by AWS
+// // Eg. resources created with cloudformation have tags that cannot be
+// // removed by an ACK controller
+// func IgnoreAWSTags(tags Tags) {
+// 	for k := range tags {
+// 		if strings.HasPrefix(k, "aws:") {
+// 			delete(tags, k)
+// 		}
+// 	}
+// }
 
 // SyncAWSTags ensures that if the latest resource has AWS tags,
 // we want the desired tags to also have those same tags. This ensures we

pkg/tags/tags.go

@@ -90,7 +90,7 @@ type AWSResourceManager interface {
 	// a resource that was created by AWS. The controller does not have
 	// permission to remove these tags, so we will just ignore them, and not
 	// patch them to the controller.
-	FilterAWSTags(AWSResource)
+	// FilterAWSTags(AWSResource)
 }
 
 // AWSResourceManagerFactory returns an AWSResourceManager that can be used to