test: DBInstance PerformanceInsightsRetentionPeriod

Author: michaelhtm

pkg/resource/db_instance/delta.go

@@ -174,6 +174,16 @@ func instanceDeleting(r *resource) bool {
 	return dbis == StatusDeleting
 }
 
+func customPreCompare(delta *ackcompare.Delta, a *resource, b *resource) {
+	if a.ko.Spec.PerformanceInsightsKMSKeyID == nil {
+		a.ko.Spec.PerformanceInsightsKMSKeyID = b.ko.Spec.PerformanceInsightsKMSKeyID
+	}
+
+	if a.ko.Spec.PerformanceInsightsRetentionPeriod == nil {
+		a.ko.Spec.PerformanceInsightsRetentionPeriod = b.ko.Spec.PerformanceInsightsRetentionPeriod
+	}
+}
+
 // function to create restoreDbInstanceFromDbSnapshot payload and call restoreDbInstanceFromDbSnapshot API
 func (rm *resourceManager) restoreDbInstanceFromDbSnapshot(
 	ctx context.Context,

pkg/resource/db_instance/hooks.go

@@ -315,9 +315,10 @@ def test_enable_pi_postgres14_t3_micro(
         assert latest is not None
         assert latest['PerformanceInsightsEnabled'] is True
 
-        # TODO: Ensure that the server side defaults
-        # (PerformanceInsightsRetentionPeriod and PerformanceInsightsKMSKeyID)
-        # are also persisted back into the spec. This currently does not work
+        assert 'performanceInsightsRetentionPeriod' in cr['spec']
+        assert 'performanceInsightsKMSKeyID' in cr['spec']
+        assert latest['PerformanceInsightsRetentionPeriod'] == cr['spec']['performanceInsightsRetentionPeriod']
+        assert latest['PerformanceInsightsKMSKeyId'] == cr['spec']['performanceInsightsKMSKeyID']
 
     def test_state_field_flapping(
             self,