Skip to content

fix: ensure function syncs when inactive #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

michaelhtm
Copy link
Member

@michaelhtm michaelhtm commented Apr 29, 2025

Issue #2446

Description of changes:
Currently the controller only marks a function resource as synced only
when it is active. We want to ensure we sync if it is inactive as well.

In Lambda function, inactive simply indicates that a function has been idle
for a long time, and we do not want the controller to keep requeueing
indefinitely

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Currently the controller only marks a function resource as synced only
when it is active. We want to ensure we sync if it is inactive as well.
@ack-prow ack-prow bot requested review from a-hilaly and rushmash91 April 29, 2025 22:04
@ack-prow ack-prow bot added the approved label Apr 29, 2025
Copy link

ack-prow bot commented Apr 29, 2025

@michaelhtm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lambda-verify-attribution 503f490 link false /test lambda-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2025
Copy link

ack-prow bot commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, michaelhtm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [a-hilaly,michaelhtm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit b91a5e7 into aws-controllers-k8s:main Apr 29, 2025
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants