-
Notifications
You must be signed in to change notification settings - Fork 212
Generate code for custom status field #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generate code for a custom status field that has a type override and has not been inferred via the normal Create Input shape or via the SourceFieldConfig. Manually construct the field and its shape reference.
Hi @nnbu. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Clean and simple |
/ok-to-test |
/retest |
2 similar comments
/retest |
/retest |
It appears the current test failures are unrelated to these changes. Controller tests are intentionally marked as optional for changes to |
@RedbackThomson Could you tell what is pending here? Does it need 2 approvers before it can be merged? |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @nnbu!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: A-Hilaly, nnbu, RedbackThomson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'll manually merge if tests fail again |
@nnbu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Looks like ec2 tests are not failing anymore and apigatewayv2 is using an oudated runtime version |
Generate code for a custom status field that has a type override and has not been inferred via the normal Create Input shape or via the SourceFieldConfig. Manually construct the field and its shape reference.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.