Skip to content

Generate code for custom status field #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

nnbu
Copy link
Contributor

@nnbu nnbu commented Jun 10, 2023

Generate code for a custom status field that has a type override and has not been inferred via the normal Create Input shape or via the SourceFieldConfig. Manually construct the field and its shape reference.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Generate code for a custom status field that has a type override and has not
been inferred via the normal Create Input shape or via the SourceFieldConfig.
Manually construct the field and its shape reference.
@ack-prow ack-prow bot requested review from jaypipes and vijtrip2 June 10, 2023 05:06
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 10, 2023
@ack-prow
Copy link

ack-prow bot commented Jun 10, 2023

Hi @nnbu. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RedbackThomson
Copy link
Contributor

Clean and simple
/approve

@RedbackThomson
Copy link
Contributor

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2023
@nnbu
Copy link
Contributor Author

nnbu commented Jun 12, 2023

/retest

2 similar comments
@nnbu
Copy link
Contributor Author

nnbu commented Jun 12, 2023

/retest

@nnbu
Copy link
Contributor Author

nnbu commented Jun 12, 2023

/retest

@RedbackThomson
Copy link
Contributor

It appears the current test failures are unrelated to these changes. Controller tests are intentionally marked as optional for changes to code-generator PRs, so these shouldn't block merging this.

@nnbu
Copy link
Contributor Author

nnbu commented Jun 13, 2023

It appears the current test failures are unrelated to these changes. Controller tests are intentionally marked as optional for changes to code-generator PRs, so these shouldn't block merging this.

@RedbackThomson Could you tell what is pending here? Does it need 2 approvers before it can be merged?

@a-hilaly
Copy link
Member

/retest

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @nnbu!
/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2023
@ack-prow
Copy link

ack-prow bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: A-Hilaly, nnbu, RedbackThomson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [A-Hilaly,RedbackThomson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the approved label Jun 14, 2023
@a-hilaly
Copy link
Member

I'll manually merge if tests fail again

@ack-prow
Copy link

ack-prow bot commented Jun 14, 2023

@nnbu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-controller-test 03237a5 link true /test ec2-controller-test
apigatewayv2-controller-test 03237a5 link true /test apigatewayv2-controller-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@a-hilaly
Copy link
Member

Looks like ec2 tests are not failing anymore and apigatewayv2 is using an oudated runtime version

@a-hilaly a-hilaly merged commit e04fca8 into aws-controllers-k8s:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants