Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectObjectContent response #157

Open
LostKobrakai opened this issue Mar 7, 2023 · 1 comment
Open

SelectObjectContent response #157

LostKobrakai opened this issue Mar 7, 2023 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@LostKobrakai
Copy link
Contributor

LostKobrakai commented Mar 7, 2023

It seems like https://docs.aws.amazon.com/AmazonS3/latest/API/RESTSelectObjectAppendix.html is only used for the https://docs.aws.amazon.com/AmazonS3/latest/API/API_SelectObjectContent.html API, though not sure from the docs. It's a binary protocol, which currently doesn't get receive_body_as_binary? set. Also I don't think there's code for decoding those responses. Not sure how this would best be solved, given it's n (wrapped) returned messages + some stats / end messages.

@onno-vos-dev
Copy link
Member

@LostKobrakai Sorry for the delay, I must have missed this issue somehow.

Considering we generate this from: s3/api-2.json where the relevant part would be:  SelectObjectContentEventStream + SelectObjectContentOutput we fail to pick up the receive_body_as_binary since it's not of type blob | string as can be seen at shapes.ex#L17 but rather it's of type structure with "eventstream":true and my guess is we're failing on that.

My best guess up until this point is that we need something similar as to: aws/aws-sdk-go#1941 which I'm guessing is somewhat related to: #169 and will require quite a bit of surgery that I could use some help with 😅 If we can get support for that, there's a bunch of API's which would be fixed up: search for eventstream: true

@onno-vos-dev onno-vos-dev added help wanted Extra attention is needed bug Something isn't working labels Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants