chore(ui-react): lint primitives (P-S) #3265

calebpollman · 2023-01-05T00:04:07Z

Description of changes

Lint all React UI primitives and related files between P and S

Issue #, if available

NA

Description of how you validated changes

yarn react lint && yarn react test

Checklist

PR description included
yarn test passes
Tests are updated
No side effects or sideEffects field updated
Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

changeset-bot · 2023-01-05T00:04:10Z

🦋 Changeset detected

Latest commit: f944eab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@aws-amplify/ui-react-core	Patch
@aws-amplify/ui-react	Patch
@aws-amplify/ui-react-native	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/react/.eslintrc.js

Co-authored-by: Scott Rees <6165315+reesscot@users.noreply.github.com>

reesscot · 2023-01-06T18:09:23Z

packages/react/src/primitives/SliderField/SliderField.tsx

@@ -43,7 +43,6 @@ const SliderFieldPrimitive: Primitive<SliderFieldProps, typeof Root> = (
    testId,
    thumbColor,
    trackSize,
-    dir,


Are we sure we didn't mean to throw this prop away?

It was unused, so technically it's no longer being thrown away 😄

Yeah, that should have been getting passed through, so your change looks correct:
https://www.radix-ui.com/docs/primitives/components/slider#root

packages/react/src/primitives/StepperField/StepperField.tsx

…nd onStepChange type description

zchenwei · 2023-01-10T19:25:07Z

packages/react/src/primitives/SwitchField/useSwitch.ts

@@ -20,7 +28,10 @@ export const useSwitch = (props: UseSwitchProps) => {
        return;
      }

-      typeof onChange === 'function' && onChange(event);
+      if (typeof onChange === 'function') {


We have a isFunction util under shared folder

Really trying not to get in to refactoring in these PRs to prevent scope creep from kicking in

packages/react/src/primitives/SearchField/__tests__/SearchField.test.tsx

packages/react/src/primitives/StepperField/useStepper.ts

calebpollman · 2023-01-10T20:41:17Z

packages/react/src/primitives/StepperField/useStepper.ts

+        setInputValue(event.target.value);
+
+        if (typeof onChange === 'function') {
+          onChange(event);


Just a note that this is a bug fix, previous to this PR onChange props passed to StepperField was never called

calebpollman · 2023-01-10T20:43:51Z

packages/react/src/primitives/types/stepperField.ts

-   * TODO:
-   * Extends StepperField props from Omit<TextFieldProps, 'onChange'>, after removing [key: string]: any from the base type
-   * and rename onStepChange to onChange


This was being rendered in the docs StepperField props table

🤦‍♂️

reesscot

LGTM, thanks for catching these issues

calebpollman added 5 commits January 4, 2023 15:04

chore(ui-react): lint primitives

8c32701

- lint S*

d0cf65b

- lint P*

b83b5e6

- lint Q*

98f68fe

- lint R*

3c2ba4a

calebpollman requested a review from a team as a code owner January 5, 2023 00:04

github-advanced-security bot found potential problems Jan 5, 2023

View reviewed changes

packages/react/.eslintrc.js Fixed Show fixed Hide fixed

calebpollman added 4 commits January 4, 2023 16:11

clean up

c8439fc

- fix react core export snapshot

69c23cc

- remove extra templateJoin util

bf5398d

Create witty-carrots-retire.md

5801493

calebpollman temporarily deployed to ci January 5, 2023 00:45 — with GitHub Actions Inactive

wlee221 previously approved these changes Jan 5, 2023

View reviewed changes

reesscot reviewed Jan 6, 2023

View reviewed changes

packages/react/.eslintrc.js Outdated Show resolved Hide resolved

reesscot reviewed Jan 6, 2023

View reviewed changes

packages/react/.eslintrc.js Outdated Show resolved Hide resolved

Update packages/react/.eslintrc.js

8b0e6b6

Co-authored-by: Scott Rees <6165315+reesscot@users.noreply.github.com>

calebpollman dismissed wlee221’s stale review via 8b0e6b6 January 6, 2023 18:06

Update packages/react/.eslintrc.js

d999543

Co-authored-by: Scott Rees <6165315+reesscot@users.noreply.github.com>

reesscot reviewed Jan 6, 2023

View reviewed changes

packages/react/src/primitives/StepperField/StepperField.tsx Show resolved Hide resolved

calebpollman temporarily deployed to ci January 6, 2023 18:23 — with GitHub Actions Inactive

calebpollman added 2 commits January 9, 2023 17:42

Merge branch 'main' into ui-react/lint-primitives

42251f9

add back Stepperfield prop desructuring, fix onChange prop handling a…

a413f6a

…nd onStepChange type description

calebpollman temporarily deployed to ci January 10, 2023 02:01 — with GitHub Actions Inactive

calebpollman force-pushed the ui-react/lint-primitives branch from db4808c to a413f6a Compare January 10, 2023 18:57

calebpollman temporarily deployed to ci January 10, 2023 19:12 — with GitHub Actions Inactive

calebpollman had a problem deploying to ci January 10, 2023 19:12 — with GitHub Actions Failure

zchenwei reviewed Jan 10, 2023

View reviewed changes

packages/react/src/primitives/SearchField/__tests__/SearchField.test.tsx Outdated Show resolved Hide resolved

zchenwei reviewed Jan 10, 2023

View reviewed changes

packages/react/src/primitives/StepperField/useStepper.ts Show resolved Hide resolved

calebpollman added 2 commits January 10, 2023 12:31

remove SearchField legacy ref test

5ac3f8a

fix docs snapshot test

f944eab

zchenwei approved these changes Jan 10, 2023

View reviewed changes

calebpollman commented Jan 10, 2023

View reviewed changes

calebpollman temporarily deployed to ci January 10, 2023 20:54 — with GitHub Actions Inactive

calebpollman had a problem deploying to ci January 10, 2023 20:54 — with GitHub Actions Failure

calebpollman temporarily deployed to ci January 10, 2023 20:54 — with GitHub Actions Inactive

calebpollman temporarily deployed to ci January 11, 2023 00:05 — with GitHub Actions Inactive

reesscot approved these changes Jan 11, 2023

View reviewed changes

calebpollman merged commit 08111e7 into main Jan 11, 2023

calebpollman deleted the ui-react/lint-primitives branch January 11, 2023 00:32

calebpollman added a commit that referenced this pull request Jan 11, 2023

fix(ui-react): fix linting issue exposed post merge of #3265

9ce2dd2

calebpollman added a commit that referenced this pull request Jan 11, 2023

fix(ui-react): fix linting issue exposed post merge of #3265 (#3288)

662da85

github-actions bot mentioned this pull request Jan 12, 2023

Version Packages #3286

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ui-react): lint primitives (P-S) #3265

chore(ui-react): lint primitives (P-S) #3265

calebpollman commented Jan 5, 2023

changeset-bot bot commented Jan 5, 2023 •

edited

Loading

reesscot Jan 6, 2023

calebpollman Jan 6, 2023

reesscot Jan 11, 2023

zchenwei Jan 10, 2023

calebpollman Jan 10, 2023

calebpollman Jan 10, 2023

reesscot Jan 11, 2023

calebpollman Jan 10, 2023 •

edited

Loading

reesscot Jan 11, 2023

reesscot left a comment

chore(ui-react): lint primitives (P-S) #3265

chore(ui-react): lint primitives (P-S) #3265

Conversation

calebpollman commented Jan 5, 2023

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

changeset-bot bot commented Jan 5, 2023 • edited Loading

🦋 Changeset detected

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

calebpollman Jan 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reesscot left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Jan 5, 2023 •

edited

Loading

calebpollman Jan 10, 2023 •

edited

Loading