-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for complete messages to be captured in a subscription #9898
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #9898 +/- ##
==========================================
+ Coverage 78.34% 83.47% +5.12%
==========================================
Files 250 253 +3
Lines 18339 18201 -138
Branches 3955 3901 -54
==========================================
+ Hits 14368 15193 +825
+ Misses 3840 2918 -922
+ Partials 131 90 -41
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Added tests and now have good codecov delta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks like it will work as you propose. It also appears to add functionality that wouldn't impact the existing behavior. Have you linked it to a real project and exercised the behavior this change plugs into?
I think its technically an API change and it would be good to have verification that its working as expected in an end to end use case.
If you've done that validation and remove the comment, this change has my approval.
@@ -184,7 +184,7 @@ export class PubSubClass { | |||
start: console.error, | |||
next: value => observer.next({ provider, value }), | |||
error: error => observer.error({ provider, error }), | |||
// complete: observer.complete, // TODO: when all completed, complete the outer one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove this comment
5b68474
to
66bfe31
Compare
Description of changes
AppSync now supports unsubscribing connections . Previously this message is not available to uses of the amplify-js libraries. This PR will allow a user to capture this completion message and take the appropriate action inside their application
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.